69220[BUGFIX] Return PSR-7 responses in EXT:extensionmanager
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+19 −19
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+5 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php4+38 −14
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+7 −2
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+29 −14
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+9 −1
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+4 −1
Review log 1924
-
Oli Bartsch uploaded patch set 1 05/20/21, 18:11
-
core-ci voted on patch set 1 V +1 05/20/21, 18:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11739
-
Jochen Roth voted on patch set 1 V +1 CR +1 05/20/21, 18:27
-
Oli Bartsch updated the commit message in patch set 2 05/20/21, 21:51
-
core-ci voted on patch set 2 V +1 05/20/21, 21:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11755
-
Jochen Roth voted on patch set 2 V +1 CR +1 05/21/21, 08:20
-
Daniel Goerz commented on patch set 2 05/21/21, 08:34
-
Oli Bartsch uploaded patch set 3 05/21/21, 08:51
-
Oli Bartsch commented on patch set 3 05/21/21, 08:52
DownloadController.php:188ReplyYes, also noticed that. I used it explicitly here to be in line with the rest of the extbase backend controllers. Actually I'm also not a big fan of using such fallback, as it somehow hides the actual intended response body. Such information should IMO always be visible in the action directly and not supplied via some fallback magic, as it's already the case for so many things in extbase. Do you agree? -
Jochen Roth voted on patch set 3 V +1 CR +1 05/21/21, 08:55
-
core-ci voted on patch set 3 V +1 05/21/21, 09:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11762
-
Daniel Goerz commented on patch set 3 05/21/21, 09:10
DownloadController.php:188ReplyI'd say $this->htmlResponse() is no magic, it is the new default of what a a "normal" action should return. Magic was only involved before, when there was nothing returned but the view was rendered nevertheless as an HTML response. I get your point with being explicit, but it is also about setting examples for people to copy and paste. The RST has the example action return $this->htmlResponse(); The core should be consistent and this is the first place we do it and immediately we differ from the documentation 😊 After all, no hard feelings, this is more a cosmetic discussion. I'd still remove the $this->view->render() calls, but wont -1 for it, though. -
Oli Bartsch uploaded patch set 4 05/21/21, 11:48
-
Oli Bartsch commented on patch set 4 05/21/21, 11:51
DownloadController.php:188ReplyAll right, changed. Will also provide another patch, streamlining the usage of $this->htmlResponse() in core's extbase backend controllers. -
core-ci voted on patch set 4 V +1 05/21/21, 11:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11768
-
Jochen Roth voted on patch set 4 V +1 CR +1 05/21/21, 12:00
-
Daniel Goerz commented on patch set 4 V -1 05/21/21, 12:55
extension zip download does not work with current patch set -
Oli Bartsch uploaded patch set 5 05/21/21, 13:21
-
Oli Bartsch commented on patch set 5 05/21/21, 13:24
Reply
Actually I was not able to reproduce this. However calling filesize() and PathUtility::basename() on the file, after deleting it, doesn't look correct. Therefore I moved the unlink() right to the end of the method. Could you please verify if this fixed it for you? -
core-ci voted on patch set 5 V +1 05/21/21, 13:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11777
-
Benni Mack voted on patch set 5 V +1 CR +1 05/21/21, 14:33
-
Jochen Roth commented on patch set 5 V +1 CR +1 05/21/21, 14:57
Zip download worked for me -
Daniel Goerz voted on patch set 5 V +2 CR +2 05/22/21, 14:58
-
Daniel Goerz merged patch set 6 05/22/21, 14:58
DownloadController.php:188