Review main Merged

69223[BUGFIX] Define missing fieldChangeFunc property

Oli Bartsch CR +2 V +2 Easy +1 −0 updated 05/20/21, 20:56

Commit message

The composer proposal view is using FormEngine
to render the composer.json content with t3editor.

Therefore, a "fake" TCA is prepared. In case, EXT:t3editor
is not installed, FormEngine automatically falls back to
TextElement. Unlike t3editor, this element requires
the property `fieldChangeFunc` to be set and will
otherwise trigger a PHP warning while calling implode()
on it.

The PHP warning is fixed by defining the property in
the fake TCA.

As you may noticed, it's not always the best idea to use
FormEngine for non-form views. A follow-up patch will
therefore replace the FormEngine rendering with direct
usage of our codemirror web component, which however
is master only.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 05/20/21, 19:52

  2. core-ci voted on patch set 1 V +1 05/20/21, 20:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11744

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/20/21, 20:13

  4. Benni Mack voted on patch set 1 V +1 CR +1 05/20/21, 20:52

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/20/21, 20:56

  6. Christian Kuhn merged patch set 2 05/20/21, 20:56