Review main Merged

69224[TASK] Use codemirror web component for composer proposal

Oli Bartsch CR +2 V +2 Normal +30 −29 updated 05/21/21, 08:36

Commit message

Previously the FormEngine t3editor element was used
for rendering the composer proposal. This however
required to fake TCA, which lead to some misbehaviour,
e.g. in case EXT:t3editor was not installed and FormEngine
automatically fell back to TextElement (see: #94179).

Since t3editor (codemirror) can also be used as a
standalone web component, the FormEngine rendering
is now replaced by directly using the mentioned
component. This results in a less error-prone
implementation and therefore also reduces the risk
of further bugs, in case FormEngine internals change.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Daniel Goerz +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Oli Bartsch uploaded patch set 1 05/20/21, 20:42

  2. core-ci voted on patch set 1 V -1 05/20/21, 20:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11749

  3. Oli Bartsch uploaded patch set 2 05/20/21, 20:57

  4. Oli Bartsch uploaded patch set 3 05/20/21, 21:06

  5. core-ci voted on patch set 2 V +1 05/20/21, 21:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11751

  6. core-ci voted on patch set 3 V +1 05/20/21, 21:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11752

  7. Christian Kuhn voted on patch set 3 V +1 05/20/21, 21:29

  8. Oli Bartsch uploaded patch set 4 05/20/21, 21:35

  9. Christian Kuhn commented on patch set 4 V +1 05/20/21, 21:43

    uh, highlighting now (sort of) 😄
  10. core-ci voted on patch set 4 V +1 05/20/21, 21:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11754

  11. Benjamin Franzke voted on patch set 4 CR +1 05/21/21, 07:18

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 05/21/21, 08:26

  13. Benjamin Franzke voted on patch set 4 V +2 CR +2 05/21/21, 08:36

  14. Benjamin Franzke merged patch set 5 05/21/21, 08:36