Review main Merged

69227[BUGFIX] Correctly resolve nested arguments in SimpleEnhancer

Oliver Hader CR +2 V +2 Normal +39 −20 updated 08/25/21, 10:11

Commit message

Having `additionalParams = &simple[id]=okay&simple[other]=other`
with the following route enhancer configuration lead to some flaws:

    routeEnhancers:
      TestSimple:
        type: Simple
        routePath: '/simple/{simple_id}'
        _arguments:
          simple_id: 'simple/id'

* generated URI contained `simple__other`, not resolving nesting
  (`/simple/okay?simple__other=other&cHash=...`)
* `PageArguments::$staticArguments` contained parameter `simple_id`
  (unresolved to actual query parameter, incorrectly marked static)
* other `PageArguments` properties contained `simple__other`
  (unresolved to actual query parameter, ignored nesting)

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Oliver Hader uploaded patch set 1 05/21/21, 10:22

  2. core-ci voted on patch set 1 V -1 05/21/21, 10:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11764

  3. Oliver Hader uploaded patch set 2 05/21/21, 10:56

  4. core-ci voted on patch set 2 V -1 05/21/21, 10:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11765

  5. Oliver Hader uploaded patch set 3 05/21/21, 10:59

  6. core-ci voted on patch set 3 V +1 05/21/21, 11:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11766

  7. Oliver Hader uploaded patch set 4 05/21/21, 13:37

  8. core-ci voted on patch set 4 V +1 05/21/21, 13:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11780

  9. Benni Mack voted on patch set 4 V +1 CR +1 05/21/21, 14:32

  10. Markus Klein voted on patch set 4 V +1 CR +1 07/02/21, 13:31

  11. Oliver Hader voted on patch set 4 V +2 CR +2 08/25/21, 10:11

  12. Oliver Hader merged patch set 5 08/25/21, 10:11