Review main Merged

69252[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

Daniel Goerz CR +2 V +2 Normal +69 −62 updated 05/25/21, 07:37

Commit message

* EXT:indexed_search
* EXT:impexp
* EXT:frontend
* EXT:form
* EXT:fluid

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1114

  1. Daniel Goerz uploaded patch set 1 05/24/21, 16:26

  2. core-ci voted on patch set 1 V +1 05/24/21, 16:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11799

  3. Daniel Goerz uploaded patch set 2 05/24/21, 17:41

  4. Daniel Goerz commented on patch set 2 05/24/21, 17:41

    This change is ready for review.
  5. Daniel Goerz commented on patch set 2 05/24/21, 17:43

    TypoScriptFrontendController.php:3568

    Not sure if this could break somehow, If so, we should ignore the error and fix this with 12.
  6. Daniel Goerz wrote 05/24/21, 17:46

    Topic set to phpstan
  7. core-ci voted on patch set 2 V -1 05/24/21, 17:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11802

  8. Benni Mack commented on patch set 2 05/24/21, 18:56

    TypoScriptFrontendController.php:3568 Reply Unresolved

    All fine.
  9. Daniel Goerz uploaded patch set 3 05/24/21, 19:00

  10. core-ci voted on patch set 3 V +1 05/24/21, 19:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11803

  11. Benni Mack voted on patch set 3 V +1 CR +1 05/24/21, 19:42

  12. Jochen Roth voted on patch set 3 V +1 CR +1 05/25/21, 07:33

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 05/25/21, 07:37

  14. Daniel Goerz merged patch set 4 05/25/21, 07:37