69252[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+5 −5
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −2
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+5 −3
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+3 −4
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+1 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ExportController.php+3 −3
- typo3/sysext/impexp/Classes/Controller/ImportController.php+14 −17
- typo3/sysext/impexp/Classes/Import.php+4 −4
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+3 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/FileContentParser.php+2 −2
Review log 1114
-
Daniel Goerz uploaded patch set 1 05/24/21, 16:26
-
core-ci voted on patch set 1 V +1 05/24/21, 16:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11799
-
Daniel Goerz uploaded patch set 2 05/24/21, 17:41
-
Daniel Goerz commented on patch set 2 05/24/21, 17:41
This change is ready for review. -
Daniel Goerz commented on patch set 2 05/24/21, 17:43
TypoScriptFrontendController.php:3568Not sure if this could break somehow, If so, we should ignore the error and fix this with 12. -
Daniel Goerz wrote 05/24/21, 17:46
Topic set to phpstan -
core-ci voted on patch set 2 V -1 05/24/21, 17:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11802
-
Benni Mack commented on patch set 2 05/24/21, 18:56
TypoScriptFrontendController.php:3568Reply UnresolvedAll fine. -
Daniel Goerz uploaded patch set 3 05/24/21, 19:00
-
core-ci voted on patch set 3 V +1 05/24/21, 19:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11803
-
Benni Mack voted on patch set 3 V +1 CR +1 05/24/21, 19:42
-
Jochen Roth voted on patch set 3 V +1 CR +1 05/25/21, 07:33
-
Daniel Goerz voted on patch set 3 V +2 CR +2 05/25/21, 07:37
-
Daniel Goerz merged patch set 4 05/25/21, 07:37