Review main Merged

69255[TASK] Resolve still more PHP 8 issues

crell CR +2 V +2 Hard +159 −138 updated 05/27/21, 11:37

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 38

Show 18 more files

Review log 1725

  1. crell uploaded patch set 1 05/24/21, 20:27

  2. core-ci voted on patch set 1 V -1 05/24/21, 20:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11805

  3. crell uploaded patch set 2 05/24/21, 21:00

  4. core-ci voted on patch set 2 V -1 05/24/21, 21:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11806

  5. crell uploaded patch set 3 05/25/21, 21:02

  6. crell commented on patch set 3 05/25/21, 21:05

    Current status on this one: I get no more errors in the log file when running acceptance tests in PHP 8, save for one "I could not retrieve the image size for file". But that was there before this patch so whatever it must have been introduced previously. 😞 However, there are still some acceptance tests failing for non-obvious reasons that still need to be addressed. That's a bit trickier though as they're JS errors or screenshot mismatches or other things that don't make it clear what the underlying error is. If someone can point me in the right direction on those that would be much appreciated.
  7. core-ci voted on patch set 3 V -1 05/25/21, 21:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11853

  8. Oliver Klee commented on patch set 3 05/25/21, 21:14

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:188 Unresolved

    This needs to default to an empty string here.
  9. crell uploaded patch set 4 05/25/21, 21:19

  10. core-ci voted on patch set 4 V +1 05/25/21, 21:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11855

  11. Oli Bartsch commented on patch set 4 05/25/21, 21:59

    InlineControlContainer.php:225

    Not sure if `?? 0` is the expected behaviour here. Since this will overwrite `$uniqueIds` each time, the key does not exist. Maybe we should use `?? null` or better check the `$child['databaseRow']['uid']` and only if set assign the value to `$uniqueIds`, as you do it some lines below.
  12. Oliver Klee wrote 05/26/21, 09:19

    Removed reviewer Oliver Klee.
  13. Christian Kuhn updated the commit message in patch set 5 05/26/21, 11:13

  14. core-ci voted on patch set 5 V +1 05/26/21, 11:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11865

  15. crell commented on patch set 5 05/26/21, 14:18

    InlineControlContainer.php:225 Reply

    Done
  16. crell uploaded patch set 6 05/26/21, 14:18

  17. core-ci voted on patch set 6 V +1 05/26/21, 14:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11869

  18. Christian Kuhn updated the commit message in patch set 7 05/26/21, 15:23

  19. core-ci voted on patch set 7 V +1 05/26/21, 15:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11874

  20. Benni Mack uploaded patch set 8 05/26/21, 18:34

  21. Benni Mack voted on patch set 8 V +1 CR +1 05/26/21, 18:35

  22. core-ci voted on patch set 8 V +1 05/26/21, 18:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11879

  23. Jochen Roth voted on patch set 8 V +1 CR +1 05/27/21, 11:01

  24. Benni Mack voted on patch set 8 V +2 CR +2 05/27/21, 11:37

  25. Benni Mack merged patch set 9 05/27/21, 11:37