Review main Merged

69256[BUGFIX] Support extra test arguments on acceptance tests

crell CR +2 V +2 Easy +13 −13 updated 05/25/21, 16:51

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. crell uploaded patch set 1 05/24/21, 21:09

  2. core-ci voted on patch set 1 V +1 05/24/21, 21:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11807

  3. Claus Due commented on patch set 1 05/24/21, 21:18

    Overall looks good - and will be really useful to be able to pass "-g failed" to codeception! I suggest also adapting the documentation in https://github.com/TYPO3/TYPO3.CMS/blob/master/Build/Scripts/runTests.sh#L184-L185 to include the acceptance runner names in the list of "-s" values that support passing the "-e" argument.
  4. Christian Kuhn uploaded patch set 2 05/25/21, 09:10

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 05/25/21, 09:11

  6. core-ci voted on patch set 2 V +1 05/25/21, 09:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11816

  7. Jochen Roth voted on patch set 2 V +1 CR +1 05/25/21, 14:12

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 05/25/21, 16:51

  9. Christian Kuhn merged patch set 3 05/25/21, 16:51