Review main Merged

69258[TASK] Deprecate Application->run callback

Benni Mack CR +2 V +2 Normal +61 −3 updated 06/04/21, 08:42

Commit message

The run() method for all Applications contained
a callback which was added in TYPO3 v7, before
proper solutions for subrequests and a more
streamlined boot process, was in place.

The additional code can now be handled via
PSR-15 middlewares. Therefore, the callback
argument in Application->run() is now marked
as deprecated.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack uploaded patch set 1 05/25/21, 10:17

  2. core-ci voted on patch set 1 V +1 05/25/21, 10:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11824

  3. Benjamin Franzke commented on patch set 1 05/26/21, 13:14

    Nice.

    CommandApplication.php:113

    As PSR-15 middlewares aren't available in console mode we should probably don't offer an alternative in this message.
  4. Oli Bartsch uploaded patch set 2 06/04/21, 08:28

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 06/04/21, 08:31

  6. Oli Bartsch commented on patch set 2 06/04/21, 08:32

    CommandApplication.php:113 Reply

    Done
  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 06/04/21, 08:32

  8. core-ci voted on patch set 2 V +1 06/04/21, 08:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12153

  9. Benjamin Franzke merged patch set 3 06/04/21, 08:42