Review main Merged

69265[BUGFIX] Do not reset validation state when validating sections

Andreas Kienast CR +2 V +2 Easy +5 −3 updated 05/27/21, 18:56

Commit message

Calling `FormEngineValidation.validate()` on a passed section resets the
overall validation state which may cause to mark fields as valid albeit
they aren't.

To solve this issue, the validation state is reset only in case no
specific section was given.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Andreas Kienast uploaded patch set 1 05/26/21, 10:00

  2. Andreas Kienast uploaded patch set 2 05/26/21, 10:01

  3. core-ci voted on patch set 1 V +1 05/26/21, 10:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11862

  4. core-ci voted on patch set 2 V +1 05/26/21, 10:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11863

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 05/26/21, 10:29

  6. Christian Kuhn commented on patch set 2 05/26/21, 15:27

    any styleguide example to play around with?
  7. Andreas Kienast commented on patch set 2 05/26/21, 15:53

    Reply

    I didn't find any, I fiddled with bootstrap_package's pages TCA override, as the header field is required.
  8. Oli Bartsch commented on patch set 2 05/26/21, 15:54

    Reply

    tx_styleguide_required can be used.
  9. Benni Mack voted on patch set 2 V +1 CR +1 05/27/21, 11:39

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 05/27/21, 11:41

  11. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/27/21, 18:56

  12. Anja Leichsenring merged patch set 3 05/27/21, 18:56