Review main Merged

69268[TASK] Change password reset functionality

Oli Bartsch CR +2 V +2 Normal +84 −14 updated 05/31/21, 19:33

Commit message

In case administrators don't want their users to
initiate the reset password process, they have to
set the global configuration option "passwordReset"
to false.

This however also prevents administrators from
using the cli command or the action in the backend
user module.

Therefore, some things changed in the password
reset implementation:

- `passwordReset` now only affects the login screen
- The CLI command is always enabled (requires shell
  access since the command is not schedulable)
- Initiating password reset in the backend can be
  managed separately with a new user TSconfig option

Also the descriptions of the global configuration
options are adjusted. Actually `passwordResetForAdmins`
previously mentioned that setting this to FALSE will
only affect the login screen, which was not the case.
It always affected all places.

In the end, this enables administrators to be more
precise when configuring the password reset functionality
in their installations.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1625

  1. Oli Bartsch uploaded patch set 1 05/26/21, 14:34

  2. core-ci voted on patch set 1 V +1 05/26/21, 14:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11870

  3. Oli Bartsch uploaded patch set 2 05/26/21, 15:14

  4. Oli Bartsch uploaded patch set 3 05/26/21, 15:18

  5. core-ci voted on patch set 2 V +1 05/26/21, 15:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11872

  6. core-ci voted on patch set 3 V +1 05/26/21, 15:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11873

  7. Oli Bartsch updated the commit message in patch set 4 05/26/21, 15:44

  8. core-ci voted on patch set 4 V +1 05/26/21, 15:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11875

  9. Oli Bartsch updated the commit message in patch set 5 05/26/21, 16:40

  10. core-ci voted on patch set 5 V +1 05/26/21, 16:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11877

  11. Oli Bartsch uploaded patch set 6 05/26/21, 16:54

  12. Oli Bartsch commented on patch set 6 05/26/21, 16:54

    This change is ready for review.
  13. core-ci voted on patch set 6 V +1 05/26/21, 17:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11878

  14. Oli Bartsch commented on patch set 6 V -1 05/27/21, 11:33

    Needs more discussion.

    ResetPasswordCommand.php:93

    Should Cli always be enabled.
  15. Jochen Roth commented on patch set 6 05/27/21, 11:43

    ResetPasswordCommand.php:93 Reply

    IMO in cli mode this should be always possible to instantiate a password reset
  16. Oli Bartsch uploaded patch set 7 05/28/21, 10:42

  17. core-ci voted on patch set 7 V -1 05/28/21, 10:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11940

  18. Oli Bartsch uploaded patch set 8 05/28/21, 10:49

  19. Oli Bartsch uploaded patch set 9 05/28/21, 10:51

  20. Oli Bartsch commented on patch set 9 05/28/21, 10:51

    ResetPasswordCommand.php:93 Reply

    Done
  21. core-ci voted on patch set 8 V -1 05/28/21, 10:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11941

  22. core-ci voted on patch set 9 V +1 05/28/21, 10:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11942

  23. Jochen Roth voted on patch set 9 V +1 CR +1 05/28/21, 13:34

  24. Richard Haeser voted on patch set 9 V +2 CR +2 05/31/21, 19:32

  25. Richard Haeser merged patch set 10 05/31/21, 19:33