69269[TASK] Deprecate ext:backend ModuleLayout view helpers
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 28
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/AbstractButtonViewHelper.php+4 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/LinkButtonViewHelper.php+2 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/ShortcutButtonViewHelper.php+2 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuItemViewHelper.php+3 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuViewHelper.php+3 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayoutViewHelper.php+3 −0
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+17 −21
- typo3/sysext/belog/Resources/Private/Layouts/Default.html+1 −4
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php3+335 −38
- typo3/sysext/beuser/Classes/Controller/BackendUserGroupController.phpdeleted+0 −171
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/beuser/Resources/Private/Layouts/Default.html+1 −39
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.html+2 −2
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+1 −10
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/CompareGroups.htmlrenamed+1 −9
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Groups.htmlrenamed+3 −11
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+0 −8
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+3 −4
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+0 −20
Show 8 more files
- typo3/sysext/beuser/ext_tables.php+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94209-BackendModuleLayoutViewHelpers.rstnew+68 −0
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+14 −10
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+30 −0
- typo3/sysext/install/Configuration/Services.yamlnew+11 −0
- typo3/sysext/install/Resources/Private/Language/BackendModule.xlf+0 −3
- typo3/sysext/install/Resources/Private/Templates/BackendModule/BackendUserConfirmation.html+51 −58
- typo3/sysext/install/Tests/Functional/Controller/BackendModuleControllerTest.php+6 −1
Review log 2128
Show 23 earlier messages
-
Christian Kuhn uploaded patch set 1 05/26/21, 15:10
-
Christian Kuhn marked it work in progress 05/26/21, 15:10
-
core-ci voted on patch set 1 V -1 05/26/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11871
-
Oli Bartsch commented on patch set 1 05/26/21, 15:36
-
Christian Kuhn commented on patch set 1 05/26/21, 15:57
BackendUserController.php:95ReplyI didn't do that since $request is not available at this point ... if extbase ever manages to hand over psr-7 compatible requests to actions, initializeAction still does not receive the request (which is stupid anyways) ... to not add additional headaches when extbase gives us psr-7 so we can drop this ugly getRequest() method here, I for now stick with creating moduleTemplate each action. But it's matter of taste. If you insist on it, I'll happily adapt. -
Christian Kuhn uploaded patch set 2 05/27/21, 10:25
-
core-ci voted on patch set 2 V -1 05/27/21, 10:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11892
-
Christian Kuhn uploaded patch set 3 05/27/21, 12:27
-
core-ci voted on patch set 3 V +1 05/27/21, 12:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11895
-
Christian Kuhn uploaded patch set 4 05/27/21, 13:32
-
Christian Kuhn marked it ready for review 05/27/21, 13:32
-
core-ci voted on patch set 4 V +1 05/27/21, 13:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11896
-
Christian Kuhn commented on patch set 4 05/27/21, 13:45
BackendUserController.php:95ReplyDone -
Christian Kuhn uploaded patch set 5 05/27/21, 13:59
-
core-ci voted on patch set 5 V +1 05/27/21, 14:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11899
-
Jochen Roth voted on patch set 5 V +1 CR +1 05/27/21, 14:21
-
Christian Kuhn uploaded patch set 6 05/27/21, 17:42
-
Jochen Roth voted on patch set 6 V +1 CR +1 05/27/21, 17:48
-
core-ci voted on patch set 6 V +1 05/27/21, 17:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11909
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 05/27/21, 17:58
-
Oli Bartsch commented on patch set 6 CR -1 05/27/21, 18:00
still on it -
Oli Bartsch uploaded patch set 7 05/27/21, 18:52
-
Oli Bartsch voted on patch set 7 V +1 CR +1 05/27/21, 18:52
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 05/27/21, 18:54
-
Jochen Roth voted on patch set 7 V +1 CR +1 05/27/21, 19:01
-
core-ci voted on patch set 7 V +1 05/27/21, 19:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11917
-
Christian Kuhn voted on patch set 7 V +2 CR +2 05/27/21, 19:05
-
Christian Kuhn merged patch set 8 05/27/21, 19:05
BackendUserController.php:95