Review main Merged

69270[BUGFIX] Fix success message of password reset command

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 05/27/21, 11:27

Commit message

To prevent information disclosure, the password reset
process does not reveal if an email was sent or not. The
corresponding methods just return void.

However, the ResetPasswordCommand always displayed
a success message, which claims an email was sent,
even though this was not the case. An example would be
a password reset request which affects an admin user,
while "passwordResetForAdmins" is disabled.

In such cases, the message is highly misleading.

To fix this, the message now only informs about the
successfully initiated password reset process and not
whether an email was sent or not. This is now consistent
with the message in the backend user module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 05/26/21, 16:39

  2. core-ci voted on patch set 1 V +1 05/26/21, 16:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11876

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/27/21, 11:11

  4. Jochen Roth voted on patch set 1 V +1 CR +1 05/27/21, 11:17

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 05/27/21, 11:27

  6. Oli Bartsch merged patch set 2 05/27/21, 11:27