Review main Merged

69271[TASK] Always use manually set canonical URL

Albrecht Köhnlein CR +2 V +2 Easy +5 −5 updated 05/27/21, 19:11

Commit message

If a canonical URL is set in the page properties, this will always be used
before checking the other options for defining the canonical URL.

Review

  • Code review CR +2 Done
    • Riny van Tiggelen +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Riny van Tiggelen +2
    • Richard Haeser +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Albrecht Köhnlein uploaded patch set 1 05/26/21, 18:43

  2. core-ci voted on patch set 1 V -1 05/26/21, 18:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11880

  3. Benni Mack commented on patch set 1 05/26/21, 19:01

    shouldn't this be a bugfix?
  4. Albrecht Köhnlein commented on patch set 1 05/26/21, 19:08

    Reply

    I was not sure about this, because I thought this could be breaking on some existing installations.
  5. Albrecht Köhnlein uploaded patch set 2 05/26/21, 19:09

  6. core-ci voted on patch set 2 V +1 05/26/21, 19:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11882

  7. Jochen Roth voted on patch set 2 V +1 CR +1 05/27/21, 08:14

  8. Richard Haeser commented on patch set 2 05/27/21, 18:29

    Reply

    We can mark it as a bug although you can argue about that, but I would definitely not backport it to v10 as it might change the canonical URLs for people in a LTS version. So IMHO I would just leave it as the patch is now: a task for master
  9. Riny van Tiggelen updated the commit message in patch set 3 05/27/21, 18:45

  10. Riny van Tiggelen voted on patch set 3 V +1 CR +1 05/27/21, 18:46

  11. Richard Haeser updated the commit message in patch set 4 05/27/21, 18:48

  12. Richard Haeser voted on patch set 4 V +1 CR +1 05/27/21, 18:49

  13. core-ci voted on patch set 3 V +1 05/27/21, 18:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11914

  14. core-ci voted on patch set 4 V +1 05/27/21, 19:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11916

  15. Riny van Tiggelen voted on patch set 4 V +1 CR +1 05/27/21, 19:11

  16. Riny van Tiggelen voted on patch set 4 V +2 CR +2 05/27/21, 19:11

  17. Riny van Tiggelen merged patch set 5 05/27/21, 19:11