Review 10.4 Merged

69272[BUGFIX] Only show contextual language information in List module

Benni Mack CR +2 V +2 Easy +25 −12 updated 05/25/21, 13:28

Commit message

The List module shows the site information next to a language,
which is not needed in case when listing languages of a single
page (where the PID is given anyways).

In addition, for pages the context is the current uid
and not the "pid" itself.

The change adapts the list, making the overview much
more practical when dealing with multiple sites.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Benni Mack commented on patch set 1 05/25/21, 07:51

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php
  2. core-ci voted on patch set 1 V -1 05/25/21, 07:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11813

  3. Benni Mack uploaded patch set 2 05/25/21, 08:02

  4. core-ci voted on patch set 2 V -1 05/25/21, 08:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11814

  5. Benni Mack uploaded patch set 3 05/25/21, 08:59

  6. core-ci voted on patch set 3 V +1 05/25/21, 09:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11815

  7. Benni Mack marked it ready for review 05/25/21, 09:11

  8. Benni Mack uploaded patch set 4 05/25/21, 10:19

  9. core-ci voted on patch set 4 V +1 05/25/21, 10:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11825

  10. Oli Bartsch uploaded patch set 5 05/25/21, 10:43

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 05/25/21, 10:44

  12. core-ci voted on patch set 5 V +1 05/25/21, 10:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11827

  13. Jochen Roth voted on patch set 5 V +1 CR +1 05/25/21, 13:28

  14. Benni Mack voted on patch set 5 V +2 CR +2 05/25/21, 13:28

  15. Benni Mack merged patch set 6 05/25/21, 13:28