Review main Merged

69295[BUGFIX] EXT:scheduler align input field and button height

Jochen Roth CR +2 V +2 Easy +7 −3 updated 05/27/21, 11:35

Commit message

This aligns the height of the input field and
the associated datepicker button in the edit
task form of EXT:scheduler.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Jochen Roth uploaded patch set 1 05/27/21, 07:19

  2. core-ci voted on patch set 1 V +1 05/27/21, 07:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11889

  3. Oli Bartsch commented on patch set 1 CR -1 05/27/21, 08:33

    EditTask.html:78

    This is a dynamic class, set by the Clearable JavaScript Module.
  4. Oli Bartsch uploaded patch set 2 05/27/21, 08:40

  5. core-ci voted on patch set 2 V +1 05/27/21, 08:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11890

  6. Jochen Roth commented on patch set 2 V +1 CR +1 05/27/21, 10:58

    EditTask.html:78 Reply

    Ack
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 05/27/21, 11:34

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 05/27/21, 11:34

  9. Christian Kuhn merged patch set 3 05/27/21, 11:35