69298[FEATURE] Add field information for pages backend layout
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/FieldInformation/BackendLayoutFromParentPage.php5new+114 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/core/Configuration/TCA/pages.php+5 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-94210-InformationAboutInheritedBackendLayout.rstnew+21 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
Review log 1923
-
Oli Bartsch uploaded patch set 1 05/27/21, 13:56
-
core-ci voted on patch set 1 V +1 05/27/21, 14:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11898
-
Jochen Roth commented on patch set 1 05/27/21, 15:01
-
Christian Kuhn commented on patch set 1 05/27/21, 15:07
BackendLayoutFromParentPage.php:29guess this one would be ok to declare @internal -
Oli Bartsch uploaded patch set 2 05/27/21, 15:15
-
Christian Kuhn voted on patch set 2 V +1 CR +1 05/27/21, 15:19
-
Oli Bartsch commented on patch set 2 05/27/21, 15:21
BackendLayoutFromParentPage.php:29ReplyDoneBackendLayoutFromParentPage.php:81ReplyDone -
core-ci voted on patch set 2 V +1 05/27/21, 15:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11901
-
Jochen Roth voted on patch set 2 V +1 CR +1 05/27/21, 15:39
-
Daniel Goerz commented on patch set 2 CR -1 05/27/21, 16:00
on it -
Daniel Goerz uploaded patch set 3 05/27/21, 16:50
-
Daniel Goerz voted on patch set 3 V +1 CR +1 05/27/21, 16:52
-
core-ci voted on patch set 3 V +1 05/27/21, 17:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11907
-
Christian Kuhn voted on patch set 3 V +1 CR +1 05/27/21, 18:19
-
Christian Kuhn voted on patch set 3 CR -1 05/27/21, 18:22
-
Christian Kuhn commented on patch set 3 05/27/21, 18:34
BackendLayoutFromParentPage.php:88Unresolvedthis icon is a hack to circumvent the restrictions from FieldInformation NodeExpansion. Imho, we shouldn't do that. *if* we decide that icons at this point are ok. it should be reflected in the api (probably by extending the expected result array similar to what FieldControl does with iconIdentifier) and then probably implemented for other field information classes, too. for now, i'll drop that icon. -
Christian Kuhn uploaded patch set 4 05/27/21, 18:38
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 05/27/21, 18:38
-
Christian Kuhn voted on patch set 4 V +1 CR +1 05/27/21, 18:40
-
Jochen Roth voted on patch set 4 V +1 CR +1 05/27/21, 18:42
-
core-ci voted on patch set 4 V +1 05/27/21, 18:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11913
-
Oli Bartsch voted on patch set 4 V +2 CR +2 05/27/21, 19:01
-
Oli Bartsch merged patch set 5 05/27/21, 19:01
BackendLayoutFromParentPage.php:81