Review main Merged

69298[FEATURE] Add field information for pages backend layout

Oli Bartsch CR +2 V +2 Normal +147 −0 updated 05/27/21, 19:01

Commit message

This patch adds a new field information which displays the
actually used backend layout for the current page,
in case the `backend_layout` field is empty and
a parent page defines `backend_layout_next_level`.

This will help editors to determine the
actually used backend layout. This was previously
often difficult. Especially in case multiple backend
layouts used the same columns config, but
differed in their frontend representation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1923

  1. Oli Bartsch uploaded patch set 1 05/27/21, 13:56

  2. core-ci voted on patch set 1 V +1 05/27/21, 14:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11898

  3. Jochen Roth commented on patch set 1 05/27/21, 15:01

    BackendLayoutFromParentPage.php:81

    Can we have something like `$languageService->sL($backendLayout->getTitle())` to load labels from language files?
  4. Christian Kuhn commented on patch set 1 05/27/21, 15:07

    BackendLayoutFromParentPage.php:29

    guess this one would be ok to declare @internal
  5. Oli Bartsch uploaded patch set 2 05/27/21, 15:15

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 05/27/21, 15:19

  7. Oli Bartsch commented on patch set 2 05/27/21, 15:21

    BackendLayoutFromParentPage.php:29 Reply

    Done

    BackendLayoutFromParentPage.php:81 Reply

    Done
  8. core-ci voted on patch set 2 V +1 05/27/21, 15:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11901

  9. Jochen Roth voted on patch set 2 V +1 CR +1 05/27/21, 15:39

  10. Daniel Goerz commented on patch set 2 CR -1 05/27/21, 16:00

    on it
  11. Daniel Goerz uploaded patch set 3 05/27/21, 16:50

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 05/27/21, 16:52

  13. core-ci voted on patch set 3 V +1 05/27/21, 17:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11907

  14. Christian Kuhn voted on patch set 3 V +1 CR +1 05/27/21, 18:19

  15. Christian Kuhn voted on patch set 3 CR -1 05/27/21, 18:22

  16. Christian Kuhn commented on patch set 3 05/27/21, 18:34

    BackendLayoutFromParentPage.php:88 Unresolved

    this icon is a hack to circumvent the restrictions from FieldInformation NodeExpansion. Imho, we shouldn't do that. *if* we decide that icons at this point are ok. it should be reflected in the api (probably by extending the expected result array similar to what FieldControl does with iconIdentifier) and then probably implemented for other field information classes, too. for now, i'll drop that icon.
  17. Christian Kuhn uploaded patch set 4 05/27/21, 18:38

  18. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/27/21, 18:38

  19. Christian Kuhn voted on patch set 4 V +1 CR +1 05/27/21, 18:40

  20. Jochen Roth voted on patch set 4 V +1 CR +1 05/27/21, 18:42

  21. core-ci voted on patch set 4 V +1 05/27/21, 18:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11913

  22. Oli Bartsch voted on patch set 4 V +2 CR +2 05/27/21, 19:01

  23. Oli Bartsch merged patch set 5 05/27/21, 19:01