Review main Merged

69299[TASK] Avoid ObjectManager->get() in ext:irre_tutorial

Christian Kuhn CR +2 V +2 Easy +0 −21 updated 05/27/21, 17:24

Commit message

The method containing the call is unused and can be dropped.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 711

  1. Christian Kuhn uploaded patch set 1 05/27/21, 14:34

  2. Christian Kuhn uploaded patch set 2 05/27/21, 15:26

  3. core-ci voted on patch set 1 V -1 05/27/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11900

  4. Christian Kuhn uploaded patch set 3 05/27/21, 15:32

  5. Christian Kuhn updated the commit message in patch set 4 05/27/21, 15:35

  6. core-ci voted on patch set 2 V +1 05/27/21, 15:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11902

  7. core-ci voted on patch set 3 V +1 05/27/21, 15:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11903

  8. core-ci voted on patch set 4 V +1 05/27/21, 15:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11904

  9. Jochen Roth voted on patch set 4 V +1 CR +1 05/27/21, 15:59

  10. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/27/21, 17:24

  11. Anja Leichsenring merged patch set 5 05/27/21, 17:24