Review main Merged

69305[BUGFIX] Update modal instances stack when hiding a modal

Andreas Kienast CR +2 V +2 Easy +5 −2 updated 05/30/21, 17:27

Commit message

The modal stack handling is slightly changed to update the instance stack
when a modal was requested to get closed already and not once a modal has
been destroyed anymore.

This fixes an issue in case a closing modal triggers a new modal which
resulted in the new modal being broken.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Richard Haeser +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 05/27/21, 21:01

  2. Andreas Kienast commented on patch set 1 05/27/21, 21:02

  3. Andreas Kienast uploaded patch set 2 05/27/21, 21:03

  4. core-ci voted on patch set 1 V +1 05/27/21, 21:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11924

  5. core-ci voted on patch set 2 V +1 05/27/21, 21:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11926

  6. Richard Haeser voted on patch set 2 V +1 CR +1 05/28/21, 11:33

  7. Markus Klein voted on patch set 2 CR +1 05/28/21, 13:31

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/30/21, 17:27

  9. Anja Leichsenring merged patch set 3 05/30/21, 17:27