69306[BUGFIX] access-restricted subpages of sysfolders return 403
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 4
Files 5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+17 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+177 −39
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+213 −0
Review log 1419
-
Benni Mack uploaded patch set 1 05/27/21, 21:02
-
core-ci voted on patch set 1 V -1 05/27/21, 21:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11925
-
Stefan Bürk uploaded patch set 2 10/02/21, 10:41
-
Stefan Bürk commented on patch set 2 10/02/21, 10:43
Added tests to cover this functionality. Without change red, with change green. Furthermore changed excpetion codes for the new condition / exception throwing as integration tests complains about duplicate exception codes. Hopefully this was okay @Benny -
Stefan Bürk updated the commit message in patch set 3 10/02/21, 10:45
-
core-ci voted on patch set 2 V +1 10/02/21, 10:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17481
-
core-ci voted on patch set 3 V +1 10/02/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17482
-
Stefan Bürk uploaded patch set 4 10/02/21, 11:23
-
core-ci voted on patch set 4 V +1 10/02/21, 11:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17484
-
Benni Mack commented on patch set 4 CR +1 10/03/21, 14:56
Thanks for the tests, Stefan. The "bugfix" is now clear to see. -
Stefan Bürk commented on patch set 4 10/03/21, 14:59
Reply
Yes, tests make the bugfix visible. Remove WIP and start voting/review ? -
Benni Mack updated the commit message in patch set 5 10/03/21, 16:55
-
core-ci voted on patch set 5 V +1 10/03/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17516
-
Stefan Bürk voted on patch set 5 CR +1 10/03/21, 17:34
-
Stefan Bürk voted on patch set 5 V +1 10/03/21, 17:45
-
Wouter Wolters voted on patch set 5 V +1 CR +1 10/04/21, 17:42
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/08/21, 16:20
-
Benni Mack voted on patch set 5 V +2 CR +2 10/10/21, 18:23
-
Benni Mack merged patch set 6 10/10/21, 18:23