Review main Merged

69306[BUGFIX] access-restricted subpages of sysfolders return 403

Benni Mack CR +2 V +2 Hard +419 −41 updated 10/10/21, 18:23

Commit message

This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted pages (e.g. fe_groups restriction) under
a sys-folder (e.g. 2021 for subpages categorized by the sys-folder 2020)
to again return a 403 error to be properly handled by a proper
error handler.

This change adds tests to ensure this functionality is always working.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 1419

  1. Benni Mack uploaded patch set 1 05/27/21, 21:02

  2. core-ci voted on patch set 1 V -1 05/27/21, 21:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11925

  3. Stefan Bürk uploaded patch set 2 10/02/21, 10:41

  4. Stefan Bürk commented on patch set 2 10/02/21, 10:43

    Added tests to cover this functionality. Without change red, with change green. Furthermore changed excpetion codes for the new condition / exception throwing as integration tests complains about duplicate exception codes. Hopefully this was okay @Benny
  5. Stefan Bürk updated the commit message in patch set 3 10/02/21, 10:45

  6. core-ci voted on patch set 2 V +1 10/02/21, 10:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17481

  7. core-ci voted on patch set 3 V +1 10/02/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17482

  8. Stefan Bürk uploaded patch set 4 10/02/21, 11:23

  9. core-ci voted on patch set 4 V +1 10/02/21, 11:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17484

  10. Benni Mack commented on patch set 4 CR +1 10/03/21, 14:56

    Thanks for the tests, Stefan. The "bugfix" is now clear to see.
  11. Stefan Bürk commented on patch set 4 10/03/21, 14:59

    Reply

    Yes, tests make the bugfix visible. Remove WIP and start voting/review ?
  12. Benni Mack updated the commit message in patch set 5 10/03/21, 16:55

  13. core-ci voted on patch set 5 V +1 10/03/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17516

  14. Stefan Bürk voted on patch set 5 CR +1 10/03/21, 17:34

  15. Stefan Bürk voted on patch set 5 V +1 10/03/21, 17:45

  16. Wouter Wolters voted on patch set 5 V +1 CR +1 10/04/21, 17:42

  17. Oli Bartsch voted on patch set 5 V +1 CR +1 10/08/21, 16:20

  18. Benni Mack voted on patch set 5 V +2 CR +2 10/10/21, 18:23

  19. Benni Mack merged patch set 6 10/10/21, 18:23