Review main Merged

69307[TASK] Simplify extension manager xml parser

Christian Kuhn CR +2 V +2 Expert +504 −1072 updated 05/28/21, 09:07

Commit message

When dealing with TER extensions in the extension manager,
the TER provides an XML file with extension details that
are parsed and loaded into a database table.

When this has been added a long time ago, two XML parsers
have been added together with a factory to select one.

Since PHP extension 'xml' is a required TYPO3 extension
since a lot of core versions, always the first parser
did the job.

The patch removes the legacy parser and the factory,
injects the parser via DI to the consuming class, merges
the abstract parser class into the now single parser,
moves the namespace, and refactors the
class towards PHP strict typing.

This leads to a significantly simplified codebase, much
easier to maintain and adapt.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1016

  1. Christian Kuhn uploaded patch set 1 05/27/21, 22:11

  2. core-ci voted on patch set 1 V -1 05/27/21, 22:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11927

  3. Christian Kuhn uploaded patch set 2 05/27/21, 22:16

  4. core-ci voted on patch set 2 V -1 05/27/21, 22:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11928

  5. Christian Kuhn uploaded patch set 3 05/27/21, 22:28

  6. Christian Kuhn updated the commit message in patch set 4 05/27/21, 22:38

  7. core-ci voted on patch set 3 V +1 05/27/21, 22:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11929

  8. core-ci voted on patch set 4 V +1 05/27/21, 22:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11930

  9. Georg Ringer voted on patch set 4 V +1 CR +1 05/28/21, 07:43

  10. Benni Mack uploaded patch set 5 05/28/21, 07:46

  11. Benni Mack uploaded patch set 6 05/28/21, 07:48

  12. core-ci voted on patch set 5 V -1 05/28/21, 07:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11936

  13. core-ci voted on patch set 6 V +1 05/28/21, 07:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11937

  14. Benni Mack voted on patch set 6 V +1 CR +1 05/28/21, 09:05

  15. Georg Ringer voted on patch set 6 V +2 CR +2 05/28/21, 09:07

  16. Georg Ringer merged patch set 7 05/28/21, 09:07