69308[TASK] Use CodeMirror for backend layout code preview
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GridEditor.ts7+14 −25
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php10+30 −2
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+0 −6
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js+1 −1
Review log 1319
-
Jochen Roth uploaded patch set 1 05/28/21, 13:11
-
core-ci voted on patch set 1 V -1 05/28/21, 13:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11943
-
Jochen Roth uploaded patch set 2 05/28/21, 13:37
-
Oli Bartsch commented on patch set 2 05/28/21, 13:45
GridEditor.ts:305Could we be more precisely here?GridEditor.ts:305Those should be const's.BackendLayoutWizardElement.php:71Any reason why we don't use textarea as fallback here, as we do at all other places?BackendLayoutWizardElement.php:71Should be added as selector in the JS ModuleBackendLayoutWizardElement.php:71Should be moved to an else part. Otherwise this is always initialized even if directly overwritten (as soon as t3editor is installed). Also proper linebreaks would be nice.BackendLayoutWizardElement.php:86What is this class for? -
Jochen Roth uploaded patch set 3 05/28/21, 13:50
-
core-ci voted on patch set 2 V -1 05/28/21, 13:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11944
-
core-ci voted on patch set 3 V +1 05/28/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11945
-
Riccardo De Contardi voted on patch set 3 V +1 05/28/21, 19:31
-
Jochen Roth uploaded patch set 4 05/31/21, 15:02
-
core-ci voted on patch set 4 V +1 05/31/21, 15:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12043
-
Jochen Roth commented on patch set 4 05/31/21, 15:11
GridEditor.ts:303ReplyNow declared as class property. But can't set a custom class for '.CodeMirror'. The classe seems unlikely to change.GridEditor.ts:305ReplyDoneGridEditor.ts:305ReplyAckBackendLayoutWizardElement.php:71ReplyNot really, felt like keeping the previous UI is a good idea. But textarea seems to be a better choice. Changed it.BackendLayoutWizardElement.php:71ReplyAckBackendLayoutWizardElement.php:71ReplyAckBackendLayoutWizardElement.php:86ReplySeems obsolete, removed it -
Oli Bartsch uploaded patch set 5 05/31/21, 19:50
-
Oli Bartsch commented on patch set 5 V +1 CR +1 05/31/21, 19:57
GridEditor.ts:303ReplyAckBackendLayoutWizardElement.php:71ReplyAckBackendLayoutWizardElement.php:86ReplyDone -
core-ci voted on patch set 5 V +1 05/31/21, 19:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12049
-
Oli Bartsch uploaded patch set 6 05/31/21, 20:01
-
core-ci voted on patch set 6 V +1 05/31/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12050
-
Oli Bartsch voted on patch set 6 V +1 CR +1 05/31/21, 21:36
-
Christian Kuhn voted on patch set 6 V +2 CR +2 06/01/21, 05:07
-
Christian Kuhn merged patch set 7 06/01/21, 05:08
GridEditor.ts:303