Review main Merged

69308[TASK] Use CodeMirror for backend layout code preview

Jochen Roth CR +2 V +2 Normal +48 −34 updated 06/01/21, 05:08

Commit message

Currently the preview of the generated code for
a backend layout uses only <code> tag.
To streamline the ui this will use the t3editor
if installed to display the generated code

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1319

  1. Jochen Roth uploaded patch set 1 05/28/21, 13:11

  2. core-ci voted on patch set 1 V -1 05/28/21, 13:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11943

  3. Jochen Roth uploaded patch set 2 05/28/21, 13:37

  4. Oli Bartsch commented on patch set 2 05/28/21, 13:45

    GridEditor.ts:303

    Let's declare this selector as class property as for the other selectors. Also I'm not sure if we should use a class, not set by us.

    GridEditor.ts:305

    Could we be more precisely here?

    GridEditor.ts:305

    Those should be const's.

    BackendLayoutWizardElement.php:71

    Any reason why we don't use textarea as fallback here, as we do at all other places?

    BackendLayoutWizardElement.php:71

    Should be added as selector in the JS Module

    BackendLayoutWizardElement.php:71

    Should be moved to an else part. Otherwise this is always initialized even if directly overwritten (as soon as t3editor is installed). Also proper linebreaks would be nice.

    BackendLayoutWizardElement.php:86

    What is this class for?
  5. Jochen Roth uploaded patch set 3 05/28/21, 13:50

  6. core-ci voted on patch set 2 V -1 05/28/21, 13:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11944

  7. core-ci voted on patch set 3 V +1 05/28/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11945

  8. Riccardo De Contardi voted on patch set 3 V +1 05/28/21, 19:31

  9. Jochen Roth uploaded patch set 4 05/31/21, 15:02

  10. core-ci voted on patch set 4 V +1 05/31/21, 15:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12043

  11. Jochen Roth commented on patch set 4 05/31/21, 15:11

    GridEditor.ts:303 Reply

    Now declared as class property. But can't set a custom class for '.CodeMirror'. The classe seems unlikely to change.

    GridEditor.ts:305 Reply

    Done

    GridEditor.ts:305 Reply

    Ack

    BackendLayoutWizardElement.php:71 Reply

    Not really, felt like keeping the previous UI is a good idea. But textarea seems to be a better choice. Changed it.

    BackendLayoutWizardElement.php:71 Reply

    Ack

    BackendLayoutWizardElement.php:71 Reply

    Ack

    BackendLayoutWizardElement.php:86 Reply

    Seems obsolete, removed it
  12. Oli Bartsch uploaded patch set 5 05/31/21, 19:50

  13. Oli Bartsch commented on patch set 5 V +1 CR +1 05/31/21, 19:57

    GridEditor.ts:303 Reply

    Ack

    BackendLayoutWizardElement.php:71 Reply

    Ack

    BackendLayoutWizardElement.php:86 Reply

    Done
  14. core-ci voted on patch set 5 V +1 05/31/21, 19:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12049

  15. Oli Bartsch uploaded patch set 6 05/31/21, 20:01

  16. core-ci voted on patch set 6 V +1 05/31/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12050

  17. Oli Bartsch voted on patch set 6 V +1 CR +1 05/31/21, 21:36

  18. Christian Kuhn voted on patch set 6 V +2 CR +2 06/01/21, 05:07

  19. Christian Kuhn merged patch set 7 06/01/21, 05:08