Review main Merged

69310[TASK] Deprecate extbase request getBaseUri()

Christian Kuhn CR +2 V +2 Normal +130 −43 updated 05/28/21, 18:35

Commit message

To further prepare extbase towards a extbase Request
object compatible with PSR-7 ServerRequestInterface, we
need some solution for those methods within existing
extbase Request that prevent immutability.

One relatively straight case are setBaseUri() and
getBaseUri(): The setter has been marked @internal in
v10 already and can be dropped, and the getter is used
just in a couple of cases.

The patch adapts usages of getBaseUri() to implement
the uri retrieval on their own based on the PSR-7
request (global access as temporary solution) and
deprecates the method. The setter is dropped.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 57

  1. Christian Kuhn uploaded patch set 1 05/28/21, 16:30

  2. Christian Kuhn uploaded patch set 2 05/28/21, 16:31

  3. core-ci voted on patch set 1 V -1 05/28/21, 16:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11948

  4. core-ci voted on patch set 2 V +1 05/28/21, 16:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11949

  5. Benni Mack voted on patch set 2 V +1 CR +1 05/28/21, 16:50

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/28/21, 18:35

  7. Anja Leichsenring merged patch set 3 05/28/21, 18:35