Review main Merged

69312[TASK] Deprecate f:be.container ViewHelper

Christian Kuhn CR +2 V +2 Normal +56 −5 updated 05/28/21, 19:22

Commit message

The fluid backend ContainerViewHelper is very similar to the
PageRenderViewHelper, with the exception that container VH
adds a default and empty ModuleTemplate leading to a default
and thus pretty useless docheader.

The main ModuleTemplate logic of backend modules should
be done within controllers and resource registration like
CSS can be done with PageRenderer VH.

The patch deprecates the ContainerViewHelper.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/28/21, 17:21

  2. Christian Kuhn uploaded patch set 2 05/28/21, 17:24

  3. core-ci voted on patch set 1 V +1 05/28/21, 17:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11951

  4. core-ci voted on patch set 2 V +1 05/28/21, 17:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11952

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 05/28/21, 18:38

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 05/28/21, 19:13

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 05/28/21, 19:22

  8. Christian Kuhn merged patch set 3 05/28/21, 19:22