Review main Merged

69313[TASK] Remove unused helper_javascript_css.html template file

Christian Kuhn CR +2 V +2 Easy +0 −9 updated 05/28/21, 19:02

Commit message

typo3/sysext/backend/Resources/Private/Templates/helper_javascript_css.html
is an unused left over since FormEngine rewrite in v7 and can be dropped.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Wolff +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Christian Wolff +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/28/21, 17:37

  2. core-ci voted on patch set 1 V +1 05/28/21, 17:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11953

  3. Christian Kuhn updated the commit message in patch set 2 05/28/21, 17:50

  4. core-ci voted on patch set 2 V +1 05/28/21, 18:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11955

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 05/28/21, 18:27

  6. Christian Wolff voted on patch set 2 V +1 CR +1 05/28/21, 18:45

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 05/28/21, 18:59

  8. Oli Bartsch merged patch set 3 05/28/21, 19:02