Review main Merged

69315[TASK] Deprecate f:base ViewHelper

Christian Kuhn CR +2 V +2 Easy +43 −3 updated 05/30/21, 17:35

Commit message

The BaseViewHelper which renders a base tag is kinda
useless in our scope: Fluid based rendering typically
takes care of markup within body tag, but base must
be in head.
In frontend, a base tag is thus almost always set using
TypoScript config.baseURL, ending up in PageRenderer.
The backend does stuff like this on a different level,
usually ending up in the PageRenderer as well.
Even with HTML mails, a base tag is uncommon and would
usually - at least in the frontend - again render via
PageRenderer.
The patch deprecates BaseViewHelper.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Christian Kuhn uploaded patch set 1 05/28/21, 20:02

  2. Christian Kuhn uploaded patch set 2 05/28/21, 20:05

  3. core-ci voted on patch set 1 V -1 05/28/21, 20:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11958

  4. core-ci voted on patch set 2 V +1 05/28/21, 20:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11959

  5. Simon Gilli voted on patch set 2 V +1 CR +1 05/30/21, 16:58

  6. Anja Leichsenring commented on patch set 3 05/30/21, 17:21

    Published edit on patch set 2.
  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/30/21, 17:21

  8. core-ci voted on patch set 3 V +1 05/30/21, 17:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12004

  9. Simon Gilli voted on patch set 3 V +1 CR +1 05/30/21, 17:33

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 05/30/21, 17:35

  11. Christian Kuhn merged patch set 4 05/30/21, 17:35