Review main Merged

69316[TASK] Deprecate extbase request getRequestUri()

Christian Kuhn CR +2 V +2 Normal +67 −22 updated 05/30/21, 16:54

Commit message

The next step towards a PSR-7 compatible request
object in extbase is to get rid of getRequestUri()
and setRequestUri().

The strategy is similar to getBaseUri() from issue
#94223: The Internal method setRequestUri() is dropped
and the unused getRequestUri() is deprecated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1116

  1. Christian Kuhn uploaded patch set 1 05/28/21, 20:43

  2. Christian Kuhn uploaded patch set 2 05/28/21, 20:45

  3. core-ci voted on patch set 1 V +1 05/28/21, 20:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11960

  4. core-ci voted on patch set 2 V +1 05/28/21, 20:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11961

  5. Oli Bartsch updated the commit message in patch set 3 05/29/21, 10:31

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 05/29/21, 10:32

  7. core-ci voted on patch set 3 V +1 05/29/21, 10:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11972

  8. Christian Kuhn uploaded patch set 4 05/29/21, 21:12

  9. Christian Kuhn updated the commit message in patch set 5 05/29/21, 21:13

  10. Christian Kuhn commented on patch set 5 05/29/21, 21:14

    rebased
  11. core-ci voted on patch set 4 V +1 05/29/21, 21:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11992

  12. core-ci voted on patch set 5 V +1 05/29/21, 21:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11993

  13. Daniel Goerz voted on patch set 5 V +1 CR +1 05/30/21, 09:41

  14. Simon Gilli voted on patch set 5 V +1 CR +1 05/30/21, 16:53

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 05/30/21, 16:54

  16. Christian Kuhn merged patch set 6 05/30/21, 16:54