Review main Merged

69317[BUGFIX] Correct ext:beuser BackendUserRepository inheritance

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 05/29/21, 20:40

Commit message

ext:beuser BackendUserRepository extends ext:extbase
BackendUserGroupRepository, which is of course bogus.
It triggers an unneeded call of extbase
BackendUserGroupRepository->initializeObject(), which
explicitely sets respectStoragePage(false) on query
settings. This is redundant since [ctrl][rootLevel] = 1
of the be_user table TCA triggers the same call via
the DataMapper.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/29/21, 00:28

  2. core-ci voted on patch set 1 V +1 05/29/21, 00:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11964

  3. Christian Kuhn updated the commit message in patch set 2 05/29/21, 01:09

  4. core-ci voted on patch set 2 V +1 05/29/21, 01:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11967

  5. Oliver Klee voted on patch set 2 CR +1 05/29/21, 08:29

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 05/29/21, 13:35

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 05/29/21, 20:40

  8. Daniel Goerz merged patch set 3 05/29/21, 20:40