69318[TASK] Clean up extbase Domain/Repository
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserGroupRepository.php+0 −5
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserRepository.php+0 −5
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserGroupRepositoryTest.phpdeleted+0 −57
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserRepositoryTest.phpdeleted+0 −57
Review log 69
-
Christian Kuhn uploaded patch set 1 05/29/21, 01:08
-
core-ci voted on patch set 1 V -1 05/29/21, 01:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11966
-
Christian Kuhn uploaded patch set 2 05/29/21, 01:41
-
Christian Kuhn updated the commit message in patch set 3 05/29/21, 01:42
-
core-ci voted on patch set 2 V +1 05/29/21, 01:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11968
-
core-ci voted on patch set 3 V +1 05/29/21, 01:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11969
-
Christian Kuhn commented on patch set 3 CR -1 05/29/21, 02:00
not 100% sure about this one after looking at forge for related issues. changing this so easily may eventually trigger other side effects with defaultQuerySettings. temp -1 for now. -
Christian Kuhn abandoned the change 05/29/21, 14:04
-
Christian Kuhn commented on patch set 3 05/29/21, 14:04
we'll do that differently.