Review main Abandoned

69318[TASK] Clean up extbase Domain/Repository

Christian Kuhn CR 0 V 0 Normal +0 −124 updated 05/29/21, 14:04

Commit message

The two default extbase repositories BackendUserRepository and
BackendUserGroupRepository don't need the initializeObject()
methods: The two tables have rootLevel=1 set in TCA, the
extbase DataMapFactory indirectly triggers the same
setRespectStoragePage() through setRootlevel().
To be not breaking, initializeObject() is kept with
empty body, so any extending class does not fail if
calling parent::initializeObject().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 69

  1. Christian Kuhn uploaded patch set 1 05/29/21, 01:08

  2. core-ci voted on patch set 1 V -1 05/29/21, 01:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11966

  3. Christian Kuhn uploaded patch set 2 05/29/21, 01:41

  4. Christian Kuhn updated the commit message in patch set 3 05/29/21, 01:42

  5. core-ci voted on patch set 2 V +1 05/29/21, 01:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11968

  6. core-ci voted on patch set 3 V +1 05/29/21, 01:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11969

  7. Christian Kuhn commented on patch set 3 CR -1 05/29/21, 02:00

    not 100% sure about this one after looking at forge for related issues. changing this so easily may eventually trigger other side effects with defaultQuerySettings. temp -1 for now.
  8. Christian Kuhn abandoned the change 05/29/21, 14:04

  9. Christian Kuhn commented on patch set 3 05/29/21, 14:04

    we'll do that differently.