Review main Merged

69319[TASK] Remove extbase Request->setMethod()

Oli Bartsch CR +2 V +2 Normal +50 −26 updated 05/29/21, 20:38

Commit message

To further prepare towards a PSR-7 Request in extbase
we have to get rid of the setMethod() method.

Therefore, the internal method setMethod() is dropped,
while the public getMethod() is adjusted to use
the PSR-7 Request. Additionally, the now unused
InvalidRequestMethodException is deprecated.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1114

  1. Oli Bartsch uploaded patch set 1 05/29/21, 11:30

  2. core-ci voted on patch set 1 V +1 05/29/21, 11:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11973

  3. Christian Kuhn commented on patch set 1 05/29/21, 11:42

    FormRuntime.php:548

    let's leave a todo here that we want to adapt this globals usage as soon as possible.
  4. Oli Bartsch commented on patch set 1 05/29/21, 11:48

    FormRuntime.php:548 Reply

    Did not add a dedicated todo here since the whole class is heavily using $GLOBALS[TYPO3_REQUEST].
  5. Christian Kuhn commented on patch set 1 05/29/21, 11:55

    FormRuntime.php:548 Reply

    Ack
  6. Christian Kuhn commented on patch set 1 CR -1 05/29/21, 12:02

    Request.php:518

    Actually, when this class implements ServerRequestInterface, getMethod() will be there again. So this deprecation does not make too much sense. I would actually keep the implementation for now, drop setMethod, and drop the .rst file again.
  7. Oli Bartsch uploaded patch set 2 05/29/21, 13:32

  8. Oli Bartsch commented on patch set 2 05/29/21, 13:33

    Request.php:518 Reply

    Done. As discussed in slack, the RST for deprecation of the exception will stay.
  9. core-ci voted on patch set 2 V -1 05/29/21, 13:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11977

  10. Oli Bartsch uploaded patch set 3 05/29/21, 13:46

  11. core-ci voted on patch set 3 V +1 05/29/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11978

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 05/29/21, 14:07

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 05/29/21, 20:38

  14. Daniel Goerz merged patch set 4 05/29/21, 20:38