69319[TASK] Remove extbase Request->setMethod()
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Christian Kuhn +1
-
Verified V +2 Done
- Daniel Goerz +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94231-DeprecateExtbaseInvalidRequestMethodException.rstnew+41 −0
- typo3/sysext/extbase/Classes/Mvc/Exception/InvalidRequestMethodException.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+0 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php2+3 −22
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+0 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1114
-
Oli Bartsch uploaded patch set 1 05/29/21, 11:30
-
core-ci voted on patch set 1 V +1 05/29/21, 11:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11973
-
Christian Kuhn commented on patch set 1 05/29/21, 11:42
-
Oli Bartsch commented on patch set 1 05/29/21, 11:48
FormRuntime.php:548ReplyDid not add a dedicated todo here since the whole class is heavily using $GLOBALS[TYPO3_REQUEST]. -
Christian Kuhn commented on patch set 1 05/29/21, 11:55
FormRuntime.php:548ReplyAck -
Christian Kuhn commented on patch set 1 CR -1 05/29/21, 12:02
Request.php:518Actually, when this class implements ServerRequestInterface, getMethod() will be there again. So this deprecation does not make too much sense. I would actually keep the implementation for now, drop setMethod, and drop the .rst file again. -
Oli Bartsch uploaded patch set 2 05/29/21, 13:32
-
Oli Bartsch commented on patch set 2 05/29/21, 13:33
Request.php:518ReplyDone. As discussed in slack, the RST for deprecation of the exception will stay. -
core-ci voted on patch set 2 V -1 05/29/21, 13:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11977
-
Oli Bartsch uploaded patch set 3 05/29/21, 13:46
-
core-ci voted on patch set 3 V +1 05/29/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11978
-
Christian Kuhn voted on patch set 3 V +1 CR +1 05/29/21, 14:07
-
Daniel Goerz voted on patch set 3 V +2 CR +2 05/29/21, 20:38
-
Daniel Goerz merged patch set 4 05/29/21, 20:38
FormRuntime.php:548