Review main Merged

69320[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

Daniel Goerz CR +2 V +2 Normal +64 −54 updated 05/30/21, 17:42

Commit message

* EXT:dashboard
* EXT:extbase
* EXT:extensionmanager
* EXT:filelist

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1215

  1. Daniel Goerz uploaded patch set 1 05/29/21, 11:57

  2. Daniel Goerz wrote 05/29/21, 11:58

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 05/29/21, 12:00

    Additionally this patch in the phpstan-typo3 package is needed: https://github.com/FriendsOfTYPO3/phpstan-typo3/pull/14/files
  4. core-ci voted on patch set 1 V +1 05/29/21, 12:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11974

  5. Oliver Klee commented on patch set 1 05/29/21, 12:26

    FrontendUser.php:112

    Was the contained class removed on purpose?
  6. Daniel Goerz commented on patch set 1 05/29/21, 12:28

    FrontendUser.php:112 Reply Unresolved

    nope, good catch
  7. Daniel Goerz uploaded patch set 2 05/29/21, 12:29

  8. core-ci voted on patch set 2 V +1 05/29/21, 12:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11976

  9. Oliver Klee commented on patch set 2 05/29/21, 14:07

    FrontendUserGroup.php:127 Unresolved

    ObjectStorage<FrontendUserGroup>
  10. Daniel Goerz uploaded patch set 3 05/29/21, 17:56

  11. core-ci voted on patch set 3 V +1 05/29/21, 18:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11984

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 05/29/21, 18:22

  13. Oliver Klee voted on patch set 3 CR +1 05/29/21, 18:30

  14. Anja Leichsenring voted on patch set 3 V +2 CR +2 05/30/21, 17:41

  15. Anja Leichsenring merged patch set 4 05/30/21, 17:42