69320[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 21
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Model/FrontendUser.php2+6 −6
- typo3/sysext/extbase/Classes/Domain/Model/FrontendUserGroup.php1+7 −7
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Join.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+12 −10
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+14 −10
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+2 −1
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+4 −4
- typo3/sysext/extensionmanager/Classes/Domain/Repository/BulkExtensionRepositoryWriter.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+2 −1
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+3 −1
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −1
Show 1 more file
Review log 1215
-
Daniel Goerz uploaded patch set 1 05/29/21, 11:57
-
Daniel Goerz wrote 05/29/21, 11:58
Topic set to phpstan -
Daniel Goerz commented on patch set 1 05/29/21, 12:00
Additionally this patch in the phpstan-typo3 package is needed: https://github.com/FriendsOfTYPO3/phpstan-typo3/pull/14/files -
core-ci voted on patch set 1 V +1 05/29/21, 12:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11974
-
Oliver Klee commented on patch set 1 05/29/21, 12:26
FrontendUser.php:112Was the contained class removed on purpose? -
Daniel Goerz commented on patch set 1 05/29/21, 12:28
FrontendUser.php:112Reply Unresolvednope, good catch -
Daniel Goerz uploaded patch set 2 05/29/21, 12:29
-
core-ci voted on patch set 2 V +1 05/29/21, 12:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11976
-
Oliver Klee commented on patch set 2 05/29/21, 14:07
FrontendUserGroup.php:127UnresolvedObjectStorage<FrontendUserGroup> -
Daniel Goerz uploaded patch set 3 05/29/21, 17:56
-
core-ci voted on patch set 3 V +1 05/29/21, 18:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11984
-
Christian Kuhn voted on patch set 3 V +1 CR +1 05/29/21, 18:22
-
Oliver Klee voted on patch set 3 CR +1 05/29/21, 18:30
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 05/30/21, 17:41
-
Anja Leichsenring merged patch set 4 05/30/21, 17:42