69321[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Jochen Roth +1
- Oliver Klee +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 45
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Cache/Frontend/AbstractFrontend.php+1 −2
- typo3/sysext/core/Classes/Core/ApplicationContext.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateForeignKeyDefinitionItem.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/CreateIndexDefinitionItem.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/IndexColumnName.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Comparator.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+3 −3
- typo3/sysext/core/Classes/Database/QueryView.php+2 −2
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php+3 −3
- typo3/sysext/core/Classes/DataHandling/Model/RecordState.php+2 −2
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+1 −1
- typo3/sysext/core/Classes/FormProtection/AbstractFormProtection.php+1 −1
- typo3/sysext/core/Classes/Http/Message.php+1 −1
- typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php+1 −1
- typo3/sysext/core/Classes/Http/Request.php+2 −2
- typo3/sysext/core/Classes/Http/ServerRequest.php+2 −2
- typo3/sysext/core/Classes/Http/Stream.php4+15 −12
- typo3/sysext/core/Classes/Http/UploadedFile.php+2 −2
Show 25 more files
- typo3/sysext/core/Classes/Imaging/ImageMagickFile.php+2 −2
- typo3/sysext/core/Classes/Locking/FileLockStrategy.php+3 −2
- typo3/sysext/core/Classes/Locking/SemaphoreLockStrategy.php+3 −2
- typo3/sysext/core/Classes/Mail/FileSpool.php+1 −1
- typo3/sysext/core/Classes/Mail/MboxTransport.php+1 −1
- typo3/sysext/core/Classes/Mail/MemorySpool.php+4 −2
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+19 −13
- typo3/sysext/core/Classes/Package/Event/AfterPackageActivationEvent.php+2 −2
- typo3/sysext/core/Classes/Package/Event/AfterPackageDeactivationEvent.php+2 −2
- typo3/sysext/core/Classes/Package/MetaData/PackageConstraint.php+2 −2
- typo3/sysext/core/Classes/Package/PackageManager.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php4+2 −2
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php2+2 −2
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −1
- typo3/sysext/core/Classes/Resource/FileReference.php+1 −1
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Classes/Routing/PageRouter.php+1 −0
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php+3 −0
- typo3/sysext/core/Classes/Routing/SiteRouteResult.php+1 −1
- typo3/sysext/core/Classes/Service/AbstractService.php+7 −7
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −1
- typo3/sysext/core/Classes/Type/File/FileInfo.php+1 −1
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+1 −1
- phpstan.neon+0 −12
Review log 1621
-
Daniel Goerz uploaded patch set 1 05/29/21, 12:23
-
core-ci voted on patch set 1 V +1 05/29/21, 12:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11975
-
Daniel Goerz uploaded patch set 2 05/30/21, 10:58
-
Daniel Goerz commented on patch set 2 05/30/21, 10:59
This change is ready for review. -
Daniel Goerz wrote 05/30/21, 11:06
Topic set to phpstan -
core-ci voted on patch set 2 V -1 05/30/21, 11:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11999
-
Daniel Goerz uploaded patch set 3 05/30/21, 11:35
-
Daniel Goerz uploaded patch set 4 05/30/21, 11:41
-
core-ci voted on patch set 3 V -1 05/30/21, 11:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12000
-
core-ci voted on patch set 4 V +1 05/30/21, 11:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12001
-
Oliver Klee commented on patch set 4 05/30/21, 15:30
Stream.php:299I propose we make the check more specific with is_resource.Stream.php:325Ditto.VimeoRenderer.php:30It can also be null (or is at least checked for null).YouTubeRenderer.php:31It can also be null (or at least it's also checked for null). -
Daniel Goerz uploaded patch set 5 05/31/21, 10:28
-
Daniel Goerz commented on patch set 5 05/31/21, 10:28
Stream.php:299ReplyDoneStream.php:325ReplyDoneVimeoRenderer.php:30ReplyIt is never set to null, thats just the inital state of any property without a default value (and we certainly dont want to annotate that on every property without a default value). So OnlineMediaHelperInterface|false is fine hereYouTubeRenderer.php:31Reply Unresolvedsee above -
core-ci voted on patch set 5 V +1 05/31/21, 10:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12024
-
Oliver Klee commented on patch set 5 05/31/21, 10:36
VimeoRenderer.php:30ReplyShouldn't we remove the === null check then? -
Jochen Roth voted on patch set 5 V +1 CR +1 06/01/21, 08:50
-
Daniel Goerz commented on patch set 5 06/01/21, 09:25
VimeoRenderer.php:30Reply UnresolvedI dont think so. It is basically checking whether the property has been initialized. Not the cleanest solution but refactoring this would be out of scope for this patch IMO. -
Oliver Klee voted on patch set 5 CR +1 06/01/21, 12:02
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 06/01/21, 17:02
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 06/01/21, 17:32
-
Anja Leichsenring merged patch set 6 06/01/21, 17:32