Review main Merged

69321[BUGFIX] Fix phpstan errors from TypesAssignedToPropertiesRule

Daniel Goerz CR +2 V +2 Normal +109 −105 updated 06/01/21, 17:32

Commit message

* EXT:core

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 45

Show 25 more files

Review log 1621

  1. Daniel Goerz uploaded patch set 1 05/29/21, 12:23

  2. core-ci voted on patch set 1 V +1 05/29/21, 12:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11975

  3. Daniel Goerz uploaded patch set 2 05/30/21, 10:58

  4. Daniel Goerz commented on patch set 2 05/30/21, 10:59

    This change is ready for review.
  5. Daniel Goerz wrote 05/30/21, 11:06

    Topic set to phpstan
  6. core-ci voted on patch set 2 V -1 05/30/21, 11:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11999

  7. Daniel Goerz uploaded patch set 3 05/30/21, 11:35

  8. Daniel Goerz uploaded patch set 4 05/30/21, 11:41

  9. core-ci voted on patch set 3 V -1 05/30/21, 11:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12000

  10. core-ci voted on patch set 4 V +1 05/30/21, 11:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12001

  11. Oliver Klee commented on patch set 4 05/30/21, 15:30

    Stream.php:299

    I propose we make the check more specific with is_resource.

    Stream.php:325

    Ditto.

    VimeoRenderer.php:30

    It can also be null (or is at least checked for null).

    YouTubeRenderer.php:31

    It can also be null (or at least it's also checked for null).
  12. Daniel Goerz uploaded patch set 5 05/31/21, 10:28

  13. Daniel Goerz commented on patch set 5 05/31/21, 10:28

    Stream.php:299 Reply

    Done

    Stream.php:325 Reply

    Done

    VimeoRenderer.php:30 Reply

    It is never set to null, thats just the inital state of any property without a default value (and we certainly dont want to annotate that on every property without a default value). So OnlineMediaHelperInterface|false is fine here

    YouTubeRenderer.php:31 Reply Unresolved

    see above
  14. core-ci voted on patch set 5 V +1 05/31/21, 10:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12024

  15. Oliver Klee commented on patch set 5 05/31/21, 10:36

    VimeoRenderer.php:30 Reply

    Shouldn't we remove the === null check then?
  16. Jochen Roth voted on patch set 5 V +1 CR +1 06/01/21, 08:50

  17. Daniel Goerz commented on patch set 5 06/01/21, 09:25

    VimeoRenderer.php:30 Reply Unresolved

    I dont think so. It is basically checking whether the property has been initialized. Not the cleanest solution but refactoring this would be out of scope for this patch IMO.
  18. Oliver Klee voted on patch set 5 CR +1 06/01/21, 12:02

  19. Anja Leichsenring voted on patch set 5 V +1 CR +1 06/01/21, 17:02

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 06/01/21, 17:32

  21. Anja Leichsenring merged patch set 6 06/01/21, 17:32