Review main Merged

69322[TASK] Remove obsolete ext:beuser ext_typoscript_setup

Christian Kuhn CR +2 V +2 Easy +0 −15 updated 05/29/21, 18:04

Commit message

Both settings are useless:
* The storagePid = 0 setting is ignored for be_users and be_groups
  queries since the extbase DataMapper sets setRespectStoragePage(false)
  automatically because both tables have TCA ctrl rootLevel = 1.
* The check for this funny 'dummy = foo' has been removed from the
  controller years ago.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/29/21, 14:17

  2. core-ci voted on patch set 1 V +1 05/29/21, 14:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11979

  3. Oli Bartsch voted on patch set 1 CR +1 05/29/21, 16:45

  4. Georg Ringer voted on patch set 1 V +1 CR +1 05/29/21, 17:55

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 05/29/21, 18:04

  6. Daniel Goerz merged patch set 2 05/29/21, 18:04