Review main Merged

69323[TASK] Avoid ObjectManager->get() for Typo3QuerySettings

Christian Kuhn CR +2 V +2 Normal +77 −80 updated 05/29/21, 20:43

Commit message

makeInstance() can be used as straight substitution
for now. Do this and clean up the test case a bit
along the way.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/29/21, 14:48

  2. core-ci voted on patch set 1 V +1 05/29/21, 14:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11980

  3. Oliver Klee voted on patch set 1 CR +1 05/29/21, 15:46

  4. Torben Hansen voted on patch set 1 V +1 CR +1 05/29/21, 17:13

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 05/29/21, 20:42

  6. Daniel Goerz merged patch set 2 05/29/21, 20:43