69323[TASK] Avoid ObjectManager->get() for Typo3QuerySettings
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Daniel Goerz +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserGroupRepository.php+2 −2
- typo3/sysext/extbase/Classes/Domain/Repository/BackendUserRepository.php+2 −2
- typo3/sysext/extbase/Classes/Domain/Repository/CategoryRepository.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserGroupRepositoryTest.php+13 −10
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/BackendUserRepositoryTest.php+13 −10
- typo3/sysext/extbase/Tests/Unit/Domain/Repository/CategoryRepositoryTest.php+7 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+38 −50
Review log 56
-
Christian Kuhn uploaded patch set 1 05/29/21, 14:48
-
core-ci voted on patch set 1 V +1 05/29/21, 14:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11980
-
Oliver Klee voted on patch set 1 CR +1 05/29/21, 15:46
-
Torben Hansen voted on patch set 1 V +1 CR +1 05/29/21, 17:13
-
Daniel Goerz voted on patch set 1 V +2 CR +2 05/29/21, 20:42
-
Daniel Goerz merged patch set 2 05/29/21, 20:43