Review main Merged

69325[TASK] Streamline method name for doc header button registration

Torben Hansen CR +2 V +2 Easy +12 −12 updated 05/30/21, 16:50

Commit message

Change method name for doc header button registration to
`registerDocHeaderButtons`, since it strictly follows the PSR-1
camelCase naming.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Torben Hansen uploaded patch set 1 05/29/21, 17:33

  2. core-ci voted on patch set 1 V +1 05/29/21, 17:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11983

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/29/21, 18:09

  4. Oliver Klee voted on patch set 1 CR +1 05/29/21, 21:18

  5. Simon Gilli voted on patch set 1 V +1 CR +1 05/30/21, 16:49

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 05/30/21, 16:49

  7. Christian Kuhn merged patch set 2 05/30/21, 16:50