Review main Merged

69326[TASK] Reduce ObjectManager->get() usages in ext:form

Christian Kuhn CR +2 V +2 Hard +91 −286 updated 05/30/21, 18:01

Commit message

ext:form is full of ObjectManager usages. This first
patch tackles a series of simple cases: Mostly things
we know can be created via makeInstance() easily or
can be injected and that are easy to test since errors
would lead to immediate BE module or FE plugin fatals.

Some places benefit by switching to DI, and the
patch does this in some cases. Some other parts are
harder to switch, for instance because they'd require
a bigger test rewrite, or raise b/w compat issues.
Those places simply switch from ObjectManager->get()
to makeInstance() for now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 24

Show 4 more files

Review log 1016

  1. Christian Kuhn uploaded patch set 1 05/29/21, 20:11

  2. Christian Kuhn uploaded patch set 2 05/29/21, 20:12

  3. core-ci voted on patch set 1 V -1 05/29/21, 20:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11986

  4. core-ci voted on patch set 2 V +1 05/29/21, 20:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11987

  5. Christian Kuhn uploaded patch set 3 05/29/21, 20:49

  6. Christian Kuhn uploaded patch set 4 05/29/21, 20:50

  7. core-ci voted on patch set 3 V -1 05/29/21, 20:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11988

  8. core-ci voted on patch set 4 V +1 05/29/21, 20:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11989

  9. Christian Kuhn updated the commit message in patch set 5 05/29/21, 21:05

  10. Christian Kuhn updated the commit message in patch set 6 05/29/21, 21:06

  11. core-ci voted on patch set 5 V +1 05/29/21, 21:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11990

  12. core-ci voted on patch set 6 V +1 05/29/21, 21:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11991

  13. Oliver Klee voted on patch set 6 CR +1 05/29/21, 21:27

  14. Simon Gilli voted on patch set 6 V +1 CR +1 05/30/21, 17:50

  15. Anja Leichsenring voted on patch set 6 V +2 CR +2 05/30/21, 18:01

  16. Anja Leichsenring merged patch set 7 05/30/21, 18:01