69326[TASK] Reduce ObjectManager->get() usages in ext:form
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Simon Gilli +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Simon Gilli +1
- core-ci +1 CI
Issues 2
Files 24
- typo3/sysext/form/Classes/Controller/AbstractBackendController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+4 −4
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/AbstractValidator.php+1 −19
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+2 −8
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionValidationService.php+3 −28
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+1 −2
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php+6 −5
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+1 −3
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+1 −2
- typo3/sysext/form/Classes/Hooks/FormElementHooks.php+5 −7
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+1 −3
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+16 −69
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+2 −2
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+1 −2
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+2 −5
- typo3/sysext/form/Configuration/Services.yaml+4 −0
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+3 −15
Show 4 more files
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+3 −16
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+2 −8
- typo3/sysext/form/Tests/Unit/Mvc/Persistence/FormPersistenceManagerTest.php+24 −75
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+5 −9
Review log 1016
-
Christian Kuhn uploaded patch set 1 05/29/21, 20:11
-
Christian Kuhn uploaded patch set 2 05/29/21, 20:12
-
core-ci voted on patch set 1 V -1 05/29/21, 20:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11986
-
core-ci voted on patch set 2 V +1 05/29/21, 20:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11987
-
Christian Kuhn uploaded patch set 3 05/29/21, 20:49
-
Christian Kuhn uploaded patch set 4 05/29/21, 20:50
-
core-ci voted on patch set 3 V -1 05/29/21, 20:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11988
-
core-ci voted on patch set 4 V +1 05/29/21, 20:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11989
-
Christian Kuhn updated the commit message in patch set 5 05/29/21, 21:05
-
Christian Kuhn updated the commit message in patch set 6 05/29/21, 21:06
-
core-ci voted on patch set 5 V +1 05/29/21, 21:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11990
-
core-ci voted on patch set 6 V +1 05/29/21, 21:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11991
-
Oliver Klee voted on patch set 6 CR +1 05/29/21, 21:27
-
Simon Gilli voted on patch set 6 V +1 CR +1 05/30/21, 17:50
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 05/30/21, 18:01
-
Anja Leichsenring merged patch set 7 05/30/21, 18:01