69327[TASK] Enable TypesAssignedToPropertiesRule in phpstan
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
Review log 1318
-
Daniel Goerz uploaded patch set 1 05/30/21, 09:45
-
Daniel Goerz wrote 05/30/21, 09:45
Topic set to phpstan -
Daniel Goerz commented on patch set 1 CR -1 05/30/21, 09:47
This change is ready for review.Patches that need to go in first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69320 https://review.typo3.org/c/Packages/TYPO3.CMS/+/69321 Also a new release of phpstan-typo3 is needed. -
Daniel Goerz marked it work in progress 05/30/21, 09:47
-
core-ci voted on patch set 1 V -1 05/30/21, 09:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11997
-
Daniel Goerz uploaded patch set 2 05/31/21, 08:56
-
core-ci voted on patch set 2 V -1 05/31/21, 09:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12017
-
Daniel Goerz uploaded patch set 3 06/01/21, 18:19
-
Daniel Goerz commented on patch set 3 06/01/21, 18:19
This change is ready for review. -
core-ci voted on patch set 3 V -1 06/01/21, 18:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12097
-
Daniel Goerz uploaded patch set 4 06/01/21, 18:36
-
core-ci voted on patch set 4 V +1 06/01/21, 18:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12100
-
Daniel Goerz uploaded patch set 5 06/01/21, 18:49
-
core-ci voted on patch set 5 V +1 06/01/21, 19:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12103
-
Christian Kuhn voted on patch set 5 V +1 CR +1 06/01/21, 19:04
-
Oli Bartsch voted on patch set 5 V +1 CR +1 06/01/21, 19:15
-
Daniel Goerz voted on patch set 5 V +2 CR +2 06/01/21, 19:17
-
Daniel Goerz merged patch set 6 06/01/21, 19:17