69328[FEATURE] Add excludePagesRecursive option to XML sitemap generation
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Riny van Tiggelen +1
-
Verified V +2 Done
- Richard Haeser +2
- Riny van Tiggelen +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-94206-AddExcludePagesRecursiveOptionToSitemapGeneration.rstnew+36 −0
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php2+7 −1
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/constants.typoscript+2 −0
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscript+2 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/excludePagesRecursive.typoscriptnew+11 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+41 −0
Review log 1318
-
Christoph Lehmann uploaded patch set 1 05/30/21, 15:34
-
core-ci voted on patch set 1 V +1 05/30/21, 15:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12002
-
Christian Kuhn commented on patch set 1 05/30/21, 16:16
Feature-94206-AddWhereClauseTreeOptionToSitemapGeneration.rst:23In general i'm not a seriously huge fan of having query snippets in TS. OTOH, we have no good substitution at hand, I however try to avoid adding new ones since at some point in time, we'll have to tackle this. In this case, the impact is also quite limited (ext:seo only), so well ... I'll not block the change. But, please access identifiers using {#uid} to make them dbal compatible (and yes, even core does not always do that, unfortunately, patches welcome). see https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/8.7/Important-80506-DbalCompatibleFieldQuotingInTypoScript.html for details (and it's probably mentioned at other places in the docs, too). -
Christoph Lehmann uploaded patch set 2 05/30/21, 19:42
-
Christoph Lehmann commented on patch set 2 05/30/21, 19:46
Feature-94206-AddWhereClauseTreeOptionToSitemapGeneration.rst:22ReplyDoneFeature-94206-AddWhereClauseTreeOptionToSitemapGeneration.rst:23ReplyTo come around having query snippets in TypoScript i changed it to a simple comma separated list of page uids. -
core-ci voted on patch set 2 V +1 05/30/21, 19:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12009
-
Richard Haeser commented on patch set 2 05/31/21, 08:16
Thanks for the patch. Can you add some functional tests to this patch to cover this feature? -
Richard Haeser uploaded patch set 3 05/31/21, 08:32
-
Richard Haeser updated the commit message in patch set 4 05/31/21, 08:35
-
core-ci voted on patch set 3 V +1 05/31/21, 08:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12015
-
core-ci voted on patch set 4 V +1 05/31/21, 08:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12016
-
Oli Bartsch commented on patch set 4 05/31/21, 10:21
PagesXmlSitemapDataProvider.php:75We could simply check for non empty array here $excludePagesRecursive !== [] -
Christoph Lehmann uploaded patch set 5 05/31/21, 17:38
-
Christoph Lehmann commented on patch set 5 05/31/21, 17:40
Reply
DonePagesXmlSitemapDataProvider.php:75ReplyYes, it's more elegant -
core-ci voted on patch set 5 V +1 05/31/21, 17:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12048
-
Riny van Tiggelen voted on patch set 5 V +1 CR +1 05/31/21, 17:52
-
Richard Haeser voted on patch set 5 V +2 CR +2 05/31/21, 19:01
-
Richard Haeser merged patch set 6 05/31/21, 19:01
Feature-94206-AddWhereClauseTreeOptionToSitemapGeneration.rst:22