69330[DOCS] Add Settings.cfg to lowlevel extension
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Daniel Goerz +1
- Oli Bartsch +1
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Lina Wolf +2
- Daniel Goerz +1
- Oli Bartsch +1
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1620
-
Sybille Peters uploaded patch set 1 05/30/21, 19:13
-
Sybille Peters updated the commit message in patch set 2 05/30/21, 19:15
-
core-ci voted on patch set 1 V +1 05/30/21, 19:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12007
-
core-ci voted on patch set 2 V +1 05/30/21, 19:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12008
-
Richard Haeser voted on patch set 2 CR +1 05/31/21, 08:45
-
Christian Kuhn commented on patch set 2 05/31/21, 10:04
-
Sybille Peters commented on patch set 2 05/31/21, 16:42
Settings.cfg:22ReplyThe idea was to include all the boilerplate from the example in case someone wants to extend it later. The entire intersphinx mapping URLs are usually included so it is not necessary to manually include them once they are needed. But I get what you mean. I pushed another patch. -
Sybille Peters uploaded patch set 3 05/31/21, 16:43
-
core-ci voted on patch set 3 V +1 05/31/21, 16:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12047
-
Richard Haeser commented on patch set 3 05/31/21, 19:19
Settings.cfg:13UnresolvedJust for my information: do we need this line? (not that into sphinx config) -
Christian Kuhn commented on patch set 3 05/31/21, 19:40
Settings.cfg:22ReplyThx for adaption :) My second thought on this was this: If we want to hint for the full reference of what is possible in this file, just add a link ;) "# Find full reference at: https://.... This could be a useful addition to *all* Settings.cfg files, maybe along with a cleanup, maybe in dedicated patch. -
Lina Wolf uploaded patch set 4 06/01/21, 19:07
-
Lina Wolf voted on patch set 4 V +1 CR +1 06/01/21, 19:09
-
Oli Bartsch voted on patch set 4 V +1 CR +1 06/01/21, 19:12
-
Christian Kuhn voted on patch set 4 V +1 CR +1 06/01/21, 19:18
-
core-ci voted on patch set 4 V +1 06/01/21, 19:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12105
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 06/01/21, 19:18
-
Daniel Goerz voted on patch set 4 V +1 CR +1 06/01/21, 19:19
-
Lina Wolf voted on patch set 4 V +2 CR +2 06/01/21, 19:43
-
Lina Wolf merged patch set 5 06/01/21, 19:44
Settings.cfg:22