Review 10.4 Merged

69331[BUGFIX] Update modal instances stack when hiding a modal

Andreas Kienast CR +2 V +2 Easy +5 −2 updated 06/02/21, 08:24

Commit message

The modal stack handling is slightly changed to update the instance stack
when a modal was requested to get closed already and not once a modal has
been destroyed anymore.

This fixes an issue in case a closing modal triggers a new modal which
resulted in the new modal being broken.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Andreas Kienast uploaded patch set 1 05/31/21, 05:06

  2. Andreas Kienast uploaded patch set 2 05/31/21, 05:07

  3. core-ci voted on patch set 1 V +1 05/31/21, 05:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12013

  4. core-ci voted on patch set 2 V +1 05/31/21, 05:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12014

  5. Richard Haeser voted on patch set 2 V +2 CR +2 06/02/21, 08:24

  6. Richard Haeser merged patch set 3 06/02/21, 08:24