Review main Merged

69338[FEATURE] Simplify sharing of backend urls

Oli Bartsch CR +2 V +2 Hard +502 −48 updated 06/08/21, 10:33

Commit message

Atfer a lot of preperation in #93048 and #93988,
it's finally possible to share URLs to TYPO3 backend
modules. Even special modules such as FormEngine.

To ease the use for editors, the ShortcutButton
is extended for a new option. If enabled, which
is the default behaviour, the shortcut button
in the module header is replaced. The new button
allows to open a dropdown with the additional
possibility to copy the URL of the current
page to the operating systems' clipboard. Next
to the already exisiting "Add shortcut" option.

Since those URLs should not contain the user
specific token, the UriBuilder features a new
constant "SHAREABLE_URL". If set as $referenceType
in one of the supporting methods, e.g. buildUriFromRoute(),
an absoulte URL without the token is returned.

To copy the URL to the operating systems' clipboard,
a new web component "CopyToClipboard" is introduced.
This component is added without any dependency to
the URL sharing functionality and can therefore be
freely used for other backend components as well.

For the new button, the font awesome "share-alt"
icon is registered in the IconRegistry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1425

  1. Oli Bartsch uploaded patch set 1 05/31/21, 15:58

  2. Oli Bartsch uploaded patch set 2 05/31/21, 16:01

  3. core-ci voted on patch set 1 V -1 05/31/21, 16:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12045

  4. core-ci voted on patch set 2 V -1 05/31/21, 16:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12046

  5. Oli Bartsch uploaded patch set 3 06/01/21, 12:59

  6. core-ci voted on patch set 3 V -1 06/01/21, 13:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12071

  7. Oli Bartsch uploaded patch set 4 06/01/21, 14:48

  8. core-ci voted on patch set 4 V +1 06/01/21, 15:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12074

  9. Oli Bartsch uploaded patch set 5 06/01/21, 16:07

  10. core-ci voted on patch set 5 V +1 06/01/21, 16:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12087

  11. Oli Bartsch uploaded patch set 6 06/01/21, 19:06

  12. core-ci voted on patch set 6 V +1 06/01/21, 19:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12104

  13. Oli Bartsch uploaded patch set 7 06/01/21, 20:02

  14. core-ci voted on patch set 7 V -1 06/01/21, 20:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12108

  15. Oli Bartsch uploaded patch set 8 06/01/21, 23:00

  16. core-ci voted on patch set 8 V -1 06/01/21, 23:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12111

  17. Oli Bartsch uploaded patch set 9 06/01/21, 23:54

  18. core-ci voted on patch set 9 V +1 06/02/21, 00:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12113

  19. Oli Bartsch uploaded patch set 10 06/02/21, 08:19

  20. core-ci voted on patch set 10 V -1 06/02/21, 08:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12119

  21. Oli Bartsch uploaded patch set 11 06/02/21, 08:41

  22. core-ci voted on patch set 11 V +1 06/02/21, 08:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12121

  23. Jochen Roth voted on patch set 11 V +1 CR +1 06/08/21, 07:29

  24. Benni Mack voted on patch set 11 V +2 CR +2 06/08/21, 10:33

  25. Benni Mack merged patch set 12 06/08/21, 10:33