Review main Merged

69355[BUGFIX] Let site configuration recognize configured languages

André Buchmann CR +2 V +2 Easy +2 −2 updated 06/01/21, 17:44

Commit message

Set inlineTopMostParentUid fallback to "null" as "0" is a valid
sys_language. "0" gives false positives in the check which languages
are already defined.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. André Buchmann uploaded patch set 1 06/01/21, 14:01

  2. core-ci voted on patch set 1 V +1 06/01/21, 14:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12072

  3. Mathias Brodala updated the commit message in patch set 2 06/01/21, 14:15

  4. core-ci voted on patch set 2 V +1 06/01/21, 14:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12073

  5. Christian Kuhn updated the commit message in patch set 3 06/01/21, 15:11

  6. Christian Kuhn commented on patch set 3 06/01/21, 15:12

    thx. sounds reasonable, but didn't had a deeper look, yet.
  7. core-ci voted on patch set 3 V +1 06/01/21, 15:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12075

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/01/21, 16:51

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 06/01/21, 17:41

  10. Daniel Goerz merged patch set 4 06/01/21, 17:44