Review 10.4 Merged

69357[TASK] Remove a library dependent view helper test

Christian Kuhn CR +2 V +2 Easy +0 −28 updated 06/01/21, 17:36

Commit message

The removed unit test mocks the system under test
and checks for specific method calls. The test
relies on AbstractTagBasedViewHelper from
TYPO3Fluid\Fluid which added a feature in 2.7.0.
This fails in core v9 and v10 which allow 2.6
and 2.7. This whitebox test is kinda useless
anyway, so we drop it.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 06/01/21, 15:54

  2. core-ci voted on patch set 1 V +1 06/01/21, 16:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12077

  3. Oliver Klee voted on patch set 1 CR +1 06/01/21, 16:35

  4. core-ci commented on patch set 1 06/01/21, 16:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12080

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/01/21, 17:08

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 06/01/21, 17:36

  7. Daniel Goerz merged patch set 2 06/01/21, 17:36