Review main Merged

69361[BUGFIX] No greedy Symfony DI in ext:install

Christian Kuhn CR +2 V +2 Easy +8 −3 updated 06/01/21, 18:37

Commit message

We recently added a Services.yaml to ext:install.
This isn't an incredible great idea since the
install tool is designed to work with uncached DI
via ServiceProviders in general.

The config made Symfony scan all classes, but
we need Symfony DI for the backend adapter class only.
The patch reduces Symfony DI registration down to this class.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • crell +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • crell +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. Christian Kuhn uploaded patch set 1 06/01/21, 17:35

  2. Anja Leichsenring updated the commit message in patch set 2 06/01/21, 17:38

  3. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/01/21, 17:41

  4. Benjamin Franzke commented on patch set 2 06/01/21, 17:47

    Services.yaml:1

    Hm, wondering whether we should add a comment like the following at the top of the file: # HEADS UP: # This file contains services for *non* install tool # context only. # Therefore all services in this file are registered explictily and # an include-all directive like `resource: '../Classes/*'` is avoided. # # All *regular* EXT:install services are to be # registered in TYPO3\CMS\Install\ServiceProvider Not 100% happy with the wording yet, maybe you or Anja can add that as nice(r) sentences? Or we can talk how two make that comment easily understandable to avoid the re-addition of the removed lines later on.
  5. core-ci voted on patch set 1 V +1 06/01/21, 17:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12094

  6. core-ci voted on patch set 2 V +1 06/01/21, 17:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12095

  7. Simon Gilli voted on patch set 2 V +1 CR +1 06/01/21, 17:53

  8. Christian Kuhn commented on patch set 2 06/01/21, 18:16

    Services.yaml:1 Reply Unresolved

    good point. will add something.
  9. Christian Kuhn uploaded patch set 3 06/01/21, 18:19

  10. Benjamin Franzke uploaded patch set 4 06/01/21, 18:19

  11. crell commented on patch set 4 V +1 CR +1 06/01/21, 18:27

    Applied locally, reinstalled, site works now.
  12. core-ci voted on patch set 3 V +1 06/01/21, 18:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12098

  13. core-ci voted on patch set 4 V +1 06/01/21, 18:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12099

  14. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/01/21, 18:37

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 06/01/21, 18:37

  16. Daniel Goerz merged patch set 5 06/01/21, 18:37