69362[TASK] Deprecate GeneralUtility::compileSelectedGetVarsFromArray
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Christian Kuhn +1
-
Verified V +2 Done
- Richard Haeser +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+16 −10
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+6 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94252-DeprecatedGeneralUtilitycompileSelectedGetVarsFromArray.rstnew+42 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php4+0 −28
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.phpnew+49 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1013
-
Oli Bartsch uploaded patch set 1 06/01/21, 22:02
-
core-ci voted on patch set 1 V +1 06/01/21, 22:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12110
-
Oli Bartsch updated the commit message in patch set 2 06/02/21, 08:50
-
core-ci voted on patch set 2 V +1 06/02/21, 09:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12122
-
Richard Haeser commented on patch set 2 06/02/21, 09:53
-
Christian Kuhn commented on patch set 2 06/02/21, 12:41
GeneralUtilityTest.php:965ReplySimply move it to UnitDeprecated. -
Oli Bartsch commented on patch set 2 06/02/21, 12:43
GeneralUtilityTest.php:965ReplySure. Tests would otherwise fail due to the trigger_error. -
Oli Bartsch uploaded patch set 3 06/02/21, 12:54
-
Oli Bartsch commented on patch set 3 06/02/21, 12:55
GeneralUtilityTest.php:965ReplyRestored the tests in the UnitDeprecated namespace. -
core-ci voted on patch set 3 V +1 06/02/21, 13:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12131
-
Christian Kuhn voted on patch set 3 V +1 CR +1 06/03/21, 11:49
-
Richard Haeser voted on patch set 3 V +2 CR +2 06/03/21, 11:58
-
Richard Haeser merged patch set 4 06/03/21, 11:58
GeneralUtilityTest.php:965