Review main Merged

69362[TASK] Deprecate GeneralUtility::compileSelectedGetVarsFromArray

Oli Bartsch CR +2 V +2 Normal +120 −38 updated 06/03/21, 11:58

Commit message

To reduce usages of GeneralUtility::_GP(),
GeneralUtility::compileSelectedGetVarsFromArray()
is deprecated. Its only usage in the core is
adjusted by accessing the PSR-7 Request
instead.

Side note: Actually also the method name is
misleading. Since _GP() is used internally,
also POST data are checked.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1013

  1. Oli Bartsch uploaded patch set 1 06/01/21, 22:02

  2. core-ci voted on patch set 1 V +1 06/01/21, 22:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12110

  3. Oli Bartsch updated the commit message in patch set 2 06/02/21, 08:50

  4. core-ci voted on patch set 2 V +1 06/02/21, 09:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12122

  5. Richard Haeser commented on patch set 2 06/02/21, 09:53

    GeneralUtilityTest.php:965

    Do you already want to remove this tests while the code is still in the codebase?
  6. Christian Kuhn commented on patch set 2 06/02/21, 12:41

    GeneralUtilityTest.php:965 Reply

    Simply move it to UnitDeprecated.
  7. Oli Bartsch commented on patch set 2 06/02/21, 12:43

    GeneralUtilityTest.php:965 Reply

    Sure. Tests would otherwise fail due to the trigger_error.
  8. Oli Bartsch uploaded patch set 3 06/02/21, 12:54

  9. Oli Bartsch commented on patch set 3 06/02/21, 12:55

    GeneralUtilityTest.php:965 Reply

    Restored the tests in the UnitDeprecated namespace.
  10. core-ci voted on patch set 3 V +1 06/02/21, 13:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12131

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 06/03/21, 11:49

  12. Richard Haeser voted on patch set 3 V +2 CR +2 06/03/21, 11:58

  13. Richard Haeser merged patch set 4 06/03/21, 11:58