Review main Merged

69365[TASK] Remove outdated comments in ShortcutButtonViewHelper

Oli Bartsch CR +2 V +2 Easy +0 −3 updated 06/02/21, 09:32

Commit message

While reworking the Shortcut API in #93093, some
arguments in the ShortcutButtonViewHelper have
been deprecated.

However, in #94209 the whole view helper has been
deprecated, which makes the mentioned comments
obsolete. Therefore, and because they might just
confuse developers on upgrading, they are removed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 06/02/21, 08:37

  2. core-ci voted on patch set 1 V +1 06/02/21, 08:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12120

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/02/21, 09:12

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 06/02/21, 09:32

  5. Daniel Goerz merged patch set 2 06/02/21, 09:32