Review main Merged

69366[TASK] Log symfony deprecation messages

Benjamin Franzke CR +2 V +2 Easy +3 −2 updated 06/09/21, 20:52

Commit message

Symfony deprecation messages are prefixed by an @-sign in order to
only be thrown if an explicit error handler for E_USER_DEPRECATED
is registered.

Other than for regular silenced errors, we want these deprecation
messages to be logged in any case, and therefore ignore
the @-sign for E_USER_DEPRECATED errors now.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Benjamin Franzke uploaded patch set 1 06/02/21, 09:43

  2. Richard Haeser voted on patch set 1 CR +1 06/02/21, 09:48

  3. core-ci voted on patch set 1 V +1 06/02/21, 09:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12123

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 06/09/21, 20:41

  5. Oli Bartsch rebased onto patch set 2 06/09/21, 20:42

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 06/09/21, 20:42

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 06/09/21, 20:42

  8. core-ci voted on patch set 2 V +1 06/09/21, 20:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12244

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 06/09/21, 20:52

  10. Oli Bartsch merged patch set 3 06/09/21, 20:52