Review main Merged

69367[TASK] Mark LanguageService container entry as deprecated

Benjamin Franzke CR +2 V +2 Hard +251 −121 updated 08/27/21, 14:33

Commit message

Only the container entry – which acts as backend for
GeneralUtility::makeInstance(LanguageService::class) is
deprecated. The class is left as-is, but should be
factored via LanguageServiceFactory.

Therefore also all the factory methods are deprecated
in order for the LanguageServiceFactory to be used instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 54

Show 34 more files

Review log 1624

  1. Benjamin Franzke uploaded patch set 1 06/02/21, 09:43

  2. core-ci voted on patch set 1 V -1 06/02/21, 09:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12124

  3. Benjamin Franzke uploaded patch set 2 06/02/21, 11:24

  4. core-ci voted on patch set 2 V +1 06/02/21, 11:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12127

  5. Benjamin Franzke uploaded patch set 3 06/02/21, 12:48

  6. core-ci voted on patch set 3 V -1 06/02/21, 13:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12130

  7. Benjamin Franzke uploaded patch set 4 06/02/21, 13:17

  8. core-ci voted on patch set 4 V -1 06/02/21, 13:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12132

  9. Benjamin Franzke uploaded patch set 5 06/02/21, 13:48

  10. core-ci voted on patch set 5 V -1 06/02/21, 13:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12133

  11. Benjamin Franzke uploaded patch set 6 06/02/21, 14:21

  12. core-ci voted on patch set 6 V -1 06/02/21, 14:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12134

  13. Benjamin Franzke uploaded patch set 7 06/02/21, 17:11

  14. Benjamin Franzke uploaded patch set 8 06/25/21, 14:30

  15. core-ci voted on patch set 8 V +1 06/25/21, 14:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12741

  16. Benni Mack voted on patch set 8 V +1 CR +1 06/25/21, 19:09

  17. Christian Kuhn commented on patch set 8 CR -1 06/27/21, 18:27

    will add entries to extension scanner and minor modifications.
  18. Christian Kuhn uploaded patch set 9 06/27/21, 18:40

  19. Christian Kuhn voted on patch set 9 V +1 CR +1 06/27/21, 18:49

  20. core-ci voted on patch set 9 V +1 06/27/21, 18:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12763

  21. Benni Mack voted on patch set 9 V +2 CR +2 06/28/21, 06:48

  22. Benni Mack merged patch set 10 06/28/21, 06:48

  23. Christian Kuhn commented on patch set 10 06/28/21, 16:28

    FinisherOptionGenerator.php:44

    something wrong here: Call to undefined method TYPO3\CMS\Core\Localization\LanguageServiceFactory::includeLLFile()
  24. Christian Kuhn commented on patch set 10 06/29/21, 09:58

    FinisherOptionGenerator.php:44 Reply Unresolved