Review 10.4 Merged

69373[BUGFIX] Re-allow pages with a trailing slash

Anja Leichsenring CR +2 V +2 Normal +58 −12 updated 06/01/21, 19:33

Commit message

This change enables the usage of pages containing a
trailing slash in their "slug" like "/my-page/subpage/"
to be working, and modifies tests to cover this use-case.

The main routing first fetches all records including the trailing slash
(= also fetches pages with a trailing slash in their slug).

The symfony routing then checks for e.g. "/my-page/" at the very end, but will fail
if the page was named "/my-page", and then re-runs the symfony routing
to find the "/my-page" request (same behavior as before).

This change therefore solves two issues:
1. Pages with a slug with a trailing slash are properly resolved
2. Pages with a slug with trailing slash can be also called via "/my-page" and (new)
  pages without a trailing slash can be called WITH the trailing slash (as before)
  keeping maximum backwards-compatibility with RealURL logic.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Anja Leichsenring commented on patch set 1 06/01/21, 18:43

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 06/01/21, 18:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12102

  3. Anja Leichsenring commented on patch set 2 06/01/21, 19:17

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 06/01/21, 19:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12106

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 06/01/21, 19:32

  6. Anja Leichsenring merged patch set 3 06/01/21, 19:33