69393[BUGFIX] Fix still more undefined variables
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Markus Klein +1
-
Verified V +2 Done
- Richard Haeser +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Classes/Configuration/TCA/UserFunctions.php+3 −3
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+5 −5
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php2+3 −3
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseDefaultLanguagePageRow.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php3+4 −4
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+3 −3
- typo3/sysext/core/Classes/DataHandling/PagePermissionAssembler.php2+5 −5
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+3 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
Review log 1318
-
crell uploaded patch set 1 06/03/21, 21:18
-
core-ci voted on patch set 1 V +1 06/03/21, 21:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12147
-
crell uploaded patch set 2 06/03/21, 21:30
-
core-ci voted on patch set 2 V +1 06/03/21, 21:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12148
-
crell uploaded patch set 3 06/04/21, 21:36
-
core-ci voted on patch set 3 V +1 06/04/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12170
-
Simon Gilli updated the commit message in patch set 4 06/09/21, 17:20
-
core-ci voted on patch set 4 V +1 06/09/21, 17:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12235
-
Markus Klein commented on patch set 4 06/09/21, 19:32
PagePermissionAssembler.php:94That's an invalid transformation. The value '0' is a valid value (specifically below), which is now treated differently. -
Markus Klein uploaded patch set 5 06/09/21, 19:43
-
Markus Klein commented on patch set 5 06/09/21, 19:43
EditDocumentController.php:2519ReplyDonePagePermissionAssembler.php:94ReplyDone -
Markus Klein voted on patch set 5 V +1 CR +1 06/09/21, 19:48
-
core-ci voted on patch set 5 V +1 06/09/21, 19:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12242
-
Richard Haeser voted on patch set 5 V +2 CR +2 06/10/21, 06:40
-
Richard Haeser merged patch set 6 06/10/21, 06:40
-
Oli Bartsch commented on patch set 6 06/10/21, 11:51
LiveSearch.php:186This should be ($GLOBALS['TCA'][$table]['ctrl']['sortby'] ?? '') ?: $GLOBALS['TCA'][$table]['ctrl']['default_sortby'] ?? ''; -
Christian Kuhn commented on patch set 6 06/10/21, 11:57
LiveSearch.php:186Replyor in this case (since sortby must be a valid fieldname *if* set): $GLOBALS['TCA'][$tableName]['ctrl']['sortby'] ?? $GLOBALS['TCA'][$tableName]['ctrl']['default_sortby'] ?? ''; -
Markus Klein commented on patch set 6 06/10/21, 12:24
LiveSearch.php:186Reply UnresolvedCorrect, I overlooked the missing check for default_sortby in my review. I opt for Christian's version.
EditDocumentController.php:2519