Review main Merged

69393[BUGFIX] Fix still more undefined variables

crell CR +2 V +2 Normal +35 −35 updated 06/10/21, 12:24

Commit message

Manual testing found a bunch more cases of undefined variables that
need to be addressed.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Markus Klein +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1318

  1. crell uploaded patch set 1 06/03/21, 21:18

  2. core-ci voted on patch set 1 V +1 06/03/21, 21:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12147

  3. crell uploaded patch set 2 06/03/21, 21:30

  4. core-ci voted on patch set 2 V +1 06/03/21, 21:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12148

  5. crell uploaded patch set 3 06/04/21, 21:36

  6. core-ci voted on patch set 3 V +1 06/04/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12170

  7. Simon Gilli updated the commit message in patch set 4 06/09/21, 17:20

  8. core-ci voted on patch set 4 V +1 06/09/21, 17:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12235

  9. Markus Klein commented on patch set 4 06/09/21, 19:32

    EditDocumentController.php:2519

    is this a safe decision? if this is not set, I would even say "bail out", something went terribly wrong.

    PagePermissionAssembler.php:94

    That's an invalid transformation. The value '0' is a valid value (specifically below), which is now treated differently.
  10. Markus Klein uploaded patch set 5 06/09/21, 19:43

  11. Markus Klein commented on patch set 5 06/09/21, 19:43

    EditDocumentController.php:2519 Reply

    Done

    PagePermissionAssembler.php:94 Reply

    Done
  12. Markus Klein voted on patch set 5 V +1 CR +1 06/09/21, 19:48

  13. core-ci voted on patch set 5 V +1 06/09/21, 19:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12242

  14. Richard Haeser voted on patch set 5 V +2 CR +2 06/10/21, 06:40

  15. Richard Haeser merged patch set 6 06/10/21, 06:40

  16. Oli Bartsch commented on patch set 6 06/10/21, 11:51

    LiveSearch.php:186

    This should be ($GLOBALS['TCA'][$table]['ctrl']['sortby'] ?? '') ?: $GLOBALS['TCA'][$table]['ctrl']['default_sortby'] ?? '';
  17. Christian Kuhn commented on patch set 6 06/10/21, 11:57

    LiveSearch.php:186 Reply

    or in this case (since sortby must be a valid fieldname *if* set): $GLOBALS['TCA'][$tableName]['ctrl']['sortby'] ?? $GLOBALS['TCA'][$tableName]['ctrl']['default_sortby'] ?? '';
  18. Markus Klein commented on patch set 6 06/10/21, 12:24

    LiveSearch.php:186 Reply Unresolved

    Correct, I overlooked the missing check for default_sortby in my review. I opt for Christian's version.