69394[BUGFIX] Fix phpstan errors from ReturnTypeRule
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/impexp/Classes/Controller/ImportController.php+3 −2
- typo3/sysext/impexp/Classes/Export.php+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php+3 −3
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+0 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php2+9 −9
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.php+3 −3
- typo3/sysext/indexed_search/Classes/Utility/IndexedSearchUtility.php+2 −2
- typo3/sysext/indexed_search/Classes/FileContentParser.php+2 −2
- typo3/sysext/indexed_search/Classes/Lexer.php+3 −3
- typo3/sysext/info/Classes/Controller/PageInformationController.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.php2+4 −3
- typo3/sysext/install/Classes/ExtensionScanner/Php/CodeStatistics.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/AbstractNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/LinkNode.php+2 −2
- typo3/sysext/install/Classes/Service/Session/FileSessionHandler.php+1 −1
- typo3/sysext/install/Classes/Service/CoreVersionService.php+1 −0
- typo3/sysext/install/Classes/Service/SessionService.php+2 −2
- typo3/sysext/install/Classes/Service/WebServerConfigurationFileService.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −2
Review log 1419
-
Daniel Goerz uploaded patch set 1 06/04/21, 07:06
-
Daniel Goerz wrote 06/04/21, 07:07
Topic set to phpstan -
core-ci voted on patch set 1 V +1 06/04/21, 07:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12152
-
Benni Mack commented on patch set 1 10/20/21, 17:51
Care to rebase? -
Anja Leichsenring commented on patch set 1 11/03/21, 14:27
all done as far as I can see. You might want to abandon. -
Benni Mack uploaded patch set 2 11/03/21, 19:14
-
Benni Mack marked it ready for review 11/03/21, 19:14
-
core-ci voted on patch set 2 V -1 11/03/21, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18815
-
Benni Mack rebased onto patch set 3 11/15/21, 09:29
-
core-ci voted on patch set 3 V -1 11/15/21, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19279
-
Benni Mack uploaded patch set 4 11/15/21, 21:24
-
core-ci voted on patch set 4 V +1 11/15/21, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19331
-
Oli Bartsch commented on patch set 4 11/16/21, 14:00
IndexSearchRepository.php:1219Since the underlying method `IndexedSearchUtility::md5inthash($str)` was changed to always return an int, "float" should not be added here, right?ConstructorArgumentMatcher.php:64I can't see this method returns any thing else than void|null. -
Oli Bartsch uploaded patch set 5 11/16/21, 21:28
-
Oli Bartsch voted on patch set 5 V +1 CR +1 11/16/21, 21:30
-
Oli Bartsch commented on patch set 5 11/16/21, 21:31
IndexSearchRepository.php:1219ReplyDoneConstructorArgumentMatcher.php:64ReplyDone -
core-ci voted on patch set 5 V +1 11/16/21, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19381
-
Benni Mack voted on patch set 5 V +2 CR +2 11/17/21, 08:20
-
Benni Mack merged patch set 6 11/17/21, 08:20