Review main Merged

69394[BUGFIX] Fix phpstan errors from ReturnTypeRule

Daniel Goerz CR +2 V +2 Normal +42 −41 updated 11/17/21, 08:20

Commit message

EXT:impexp
EXT:indexed_search
EXT:info
EXT:install

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1419

  1. Daniel Goerz uploaded patch set 1 06/04/21, 07:06

  2. Daniel Goerz wrote 06/04/21, 07:07

    Topic set to phpstan
  3. core-ci voted on patch set 1 V +1 06/04/21, 07:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12152

  4. Benni Mack commented on patch set 1 10/20/21, 17:51

    Care to rebase?
  5. Anja Leichsenring commented on patch set 1 11/03/21, 14:27

    all done as far as I can see. You might want to abandon.
  6. Benni Mack uploaded patch set 2 11/03/21, 19:14

  7. Benni Mack marked it ready for review 11/03/21, 19:14

  8. core-ci voted on patch set 2 V -1 11/03/21, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18815

  9. Benni Mack rebased onto patch set 3 11/15/21, 09:29

  10. core-ci voted on patch set 3 V -1 11/15/21, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19279

  11. Benni Mack uploaded patch set 4 11/15/21, 21:24

  12. core-ci voted on patch set 4 V +1 11/15/21, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19331

  13. Oli Bartsch commented on patch set 4 11/16/21, 14:00

    IndexSearchRepository.php:1219

    Since the underlying method `IndexedSearchUtility::md5inthash($str)` was changed to always return an int, "float" should not be added here, right?

    ConstructorArgumentMatcher.php:64

    I can't see this method returns any thing else than void|null.
  14. Oli Bartsch uploaded patch set 5 11/16/21, 21:28

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 11/16/21, 21:30

  16. Oli Bartsch commented on patch set 5 11/16/21, 21:31

    IndexSearchRepository.php:1219 Reply

    Done

    ConstructorArgumentMatcher.php:64 Reply

    Done
  17. core-ci voted on patch set 5 V +1 11/16/21, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19381

  18. Benni Mack voted on patch set 5 V +2 CR +2 11/17/21, 08:20

  19. Benni Mack merged patch set 6 11/17/21, 08:20